Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection UI regressions #10771

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

jamakase
Copy link
Contributor

@jamakase jamakase commented Mar 1, 2022

What

Fixes a problem that form was reinitialized when values of sync was changed Closes #10671

How

As the form is not split into 2 separate subforms - they shouldn't be reinitialized when values from some forms are changed. The problem was that not all values were sent to backend from sync form - as a result, some values were changed in the background and catalog form was reinitialized.

@jamakase jamakase self-assigned this Mar 1, 2022
@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Mar 1, 2022
@jamakase jamakase temporarily deployed to more-secrets March 1, 2022 18:45 Inactive
@jamakase jamakase temporarily deployed to more-secrets March 1, 2022 18:45 Inactive
@jamakase jamakase marked this pull request as ready for review March 3, 2022 08:10
@jamakase jamakase requested a review from a team as a code owner March 3, 2022 08:10
Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally, Chrome Linux. Seems to resolve the 1st and 3rd mentioned regression to me. I wasn't able to reproduce the 2nd bug mentioned in the issue without this change.

@jamakase jamakase merged commit f77fa8b into master Mar 5, 2022
@jamakase jamakase deleted the jamakase/fix-connection-ui-regressions branch March 5, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several regressions in the new connection UI
2 participants