Remove the attemptId notion in the connectionManagerWorkflow

[benmoriceau]

What

This is removing the attemptId from the create attempt activity to replace it with the attemptNumber. This will be modified in the workflow in a later commit.

[davinchia]

Benoit, can you explain more why replacing the attempt id with the attempt number is better? Probably a dumb question, what's the difference between the attempt id and the attempt number?

[benmoriceau]

Benoit, can you explain more why replacing the attempt id with the attempt number is better? Probably a dumb question, what's the difference between the attempt id and the attempt number?

It is to help understanding what represent the attemptId/Attempt number that we have in the temporal workflow. The doc in airbyte-scheduler/persistence/src/main/java/io/airbyte/scheduler/persistence/JobPersistence.java was missleading because the implementation is returning the attemptNumber instead of the attemptId. The goal is to remove the confusion because here attemptId we use in the temporal workflow is actually an attempt number.

Here is the persistence implementation (just the return that select the number):

return ctx.fetch(
          "INSERT INTO attempts(job_id, attempt_number, log_path, status, created_at, updated_at) VALUES(?, ?, ?, CAST(? AS ATTEMPT_STATUS), ?, ?) RETURNING attempt_number",
          jobId,
          job.getAttemptsCount(),
          logPath.toString(),
          Sqls.toSqlName(AttemptStatus.RUNNING),
          now,
          now)
          .stream()
          .findFirst()
          .map(r -> r.get("attempt_number", Integer.class))
          .orElseThrow(() -> new RuntimeException("This should not happen"));
    });