Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悪 octavia-cli: use yaml safe load #10882

Merged
merged 1 commit into from
Mar 8, 2022
Merged

馃悪 octavia-cli: use yaml safe load #10882

merged 1 commit into from
Mar 8, 2022

Conversation

alafanechere
Copy link
Contributor

According to PyYaml doc:

Warning: It is not safe to call yaml.load with any data received from an untrusted source! yaml.load is as powerful as pickle.load and so may call any Python function. Check the yaml.safe_load function though.

Use safe_load to open yaml file securely with the SafeLoader.

@alafanechere alafanechere added this to the octavia-cli-alpha milestone Mar 5, 2022
@alafanechere alafanechere mentioned this pull request Mar 6, 2022
Closed
marcosmarxm
marcosmarxm approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alafanechere alafanechere merged commit a9ac813 into master Mar 8, 2022
@alafanechere alafanechere deleted the augustin/octavia-cli/yaml-safe-load branch March 8, 2022 10:52
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Mar 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/octavia-cli
Projects
None yet
Milestone
octavia-cli-alpha
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alafanechere @marcosmarxm