Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClickHouse normalization update #10905

Merged
merged 9 commits into from Mar 28, 2022
Merged

Conversation

wbchn
Copy link
Contributor

@wbchn wbchn commented Mar 7, 2022

  1. update [Backport] 4091聽dbt-labs/dbt-core#4112
  2. ClickHouse not contain boolean, using 1/0 instead of true/false.
  3. ClickHouse unnest with ARRAY JOIN, and make un-nullable type in JSONExtra.

What

Describe what the change is solving

How

Describe the solution

  1. update [Backport] 4091聽dbt-labs/dbt-core#4112
  2. ClickHouse not contain boolean, using 1/0 instead of true/false.
  3. ClickHouse unnest with ARRAY JOIN, and make un-nullable type in JSONExtraXXX function.

Recommended reading order

  1. x.java
  2. y.python

馃毃 User Impact 馃毃

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 馃毃馃毃 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

2. ClickHouse not contain boolean, using 1/0 instead of true/false.
3. ClickHouse unnest with `ARRAY JOIN`, and make un-nullable type in JSONExtra.
@CLAassistant
Copy link

CLAassistant commented Mar 7, 2022

CLA assistant check
All committers have signed the CLA.

@marcosmarxm
Copy link
Member

thanks for the contribution @wbchn I'll review and test it tomorrow

@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/platform issues related to the platform area/worker Related to worker labels Mar 28, 2022
@marcosmarxm marcosmarxm merged commit 92eab0f into airbytehq:master Mar 28, 2022
@marcosmarxm marcosmarxm temporarily deployed to more-secrets March 28, 2022 19:45 Inactive
@wbchn wbchn deleted the clickhouse branch March 29, 2022 03:13
@wbchn wbchn restored the clickhouse branch March 29, 2022 03:13
@arashlayeghi
Copy link

@wbchn @marcosmarxm
Thanks a lot for this fix. When the new version of clickhouse will be released?

@marcosmarxm
Copy link
Member

@arashlayeghi this will be enabled in next Airbyte releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation area/platform issues related to the platform area/worker Related to worker community normalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants