Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Facebook Marketing: Add temporary OAuth error handling #10917

Merged

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Mar 7, 2022

What

#10139 - Fix backoff trigger with teporary OAuthException

How

Added code 2 to backoff errors code list.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Mar 7, 2022
@lazebnyi lazebnyi linked an issue Mar 7, 2022 that may be closed by this pull request
@lazebnyi lazebnyi temporarily deployed to more-secrets March 7, 2022 12:57 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets March 7, 2022 12:57 Inactive
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@lazebnyi lazebnyi temporarily deployed to more-secrets March 9, 2022 12:35 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets March 9, 2022 12:35 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets March 9, 2022 12:43 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets March 9, 2022 12:43 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets March 9, 2022 12:48 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets March 9, 2022 12:48 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets March 9, 2022 12:52 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets March 9, 2022 12:52 Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Mar 9, 2022

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1957334695
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1957334695
🐛 https://gradle.com/s/gxulwbb3p33ac

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Mar 9, 2022

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1957520590
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1957520590
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              33      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/api.py                               97     13    87%
source_facebook_marketing/streams/base_streams.py             127     27    79%
source_facebook_marketing/streams/common.py                    41     13    68%
source_facebook_marketing/streams/streams.py                   97     32    67%
source_facebook_marketing/source.py                            35     13    63%
source_facebook_marketing/streams/base_insight_streams.py     129     54    58%
source_facebook_marketing/streams/async_job.py                204    128    37%
source_facebook_marketing/streams/async_job_manager.py         74     56    24%
-------------------------------------------------------------------------------
TOTAL                                                         841    336    60%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/async_job.py                204      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              33      0   100%
source_facebook_marketing/source.py                            35      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/streams/common.py                    41      1    98%
source_facebook_marketing/streams/async_job_manager.py         74      3    96%
source_facebook_marketing/streams/base_insight_streams.py     129     13    90%
source_facebook_marketing/api.py                               97     16    84%
source_facebook_marketing/streams/streams.py                   97     22    77%
source_facebook_marketing/streams/base_streams.py             127     30    76%
-------------------------------------------------------------------------------
TOTAL                                                         841     85    90%

@lazebnyi lazebnyi temporarily deployed to more-secrets March 9, 2022 13:32 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets March 9, 2022 13:32 Inactive
@lazebnyi lazebnyi marked this pull request as ready for review March 9, 2022 13:51
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Mar 9, 2022

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1957848982
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1957848982

@lazebnyi lazebnyi merged commit c6caf14 into master Mar 10, 2022
@lazebnyi lazebnyi deleted the lazebnyi/10139-facebook-marketing-handle-temporary-oauth-error branch March 10, 2022 12:36
@lazebnyi lazebnyi temporarily deployed to more-secrets March 10, 2022 12:37 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets March 10, 2022 12:38 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facebook marketing sync fails
3 participants