Fix Sonar check for non-python based connectors #10928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick fix that moves cat ${REPORT_FOLDER}/*
inside if block for python-based connectors.
|
/test connector=connectors/destination-s3
|
sherifnada
approved these changes
Mar 8, 2022
|
@antixar is on OOO until further notice (military duty) so feel free to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is a quick fix that moves
cat ${REPORT_FOLDER}/*inside if block for python-based connectors.
How
The temporary fix is to move
cat ${REPORT_FOLDER}/*inside the if block for python-based connectors. This will unbreak Sonar checks for java-based connectors. However, the remaining work that is still TBD is to make sure that Sonar generates reports correctly for Java-based connectors as well as for python-based ones.