Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Source Smartsheets: resolve #8099 and add support for syncing row metadata #11003

Closed
wants to merge 40 commits into from

Conversation

zzstoatzz
Copy link
Contributor

@zzstoatzz zzstoatzz commented Mar 9, 2022

What

Resolves this issue and adds the option to include row metadata directly in the synced rows

How

  • scrambled kv pairs: explicitly map column id's to names during construction of each AirbyteRecord
  • metadata: Add boolean flag to spec.json to include_metadata or not

馃毃 User Impact 馃毃

TODO

Pre-merge Checklist

TODO

Community member or Airbyter

TODO

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

n/a

Integration and Acceptance Tests
$ ./gradlew :airbyte-integrations:connectors:source-smartsheets:integrationTest

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 20 passed, 1 skipped in 24.56s ========================


BUILD SUCCESSFUL in 57s
81 actionable tasks: 44 executed, 37 up-to-date

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Mar 9, 2022
@zzstoatzz zzstoatzz changed the title resolve #8099 and add support for syncing row metadata 馃悰 resolve #8099 and add support for syncing row metadata Mar 10, 2022
@zzstoatzz zzstoatzz changed the title 馃悰 resolve #8099 and add support for syncing row metadata 馃悰 Source Smartsheets: resolve #8099 and add support for syncing row metadata Mar 10, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Mar 14, 2022
@zzstoatzz zzstoatzz marked this pull request as ready for review March 14, 2022 23:22
@alafanechere
Copy link
Contributor

Hey @zzstoatzz , you pushed a lot of binaries and master diverged a lot from your branch since you opened this PR. Do you mind opening a new one if you still want these changes to happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to the api area/connectors Connector related issues area/documentation Improvements or additions to documentation area/platform issues related to the platform area/protocol area/scheduler bounty community connectors/source/smartsheets
Projects
Development

Successfully merging this pull request may close these issues.

Smartsheets connector raw key:value pair data is scrambled.
4 participants