Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Pivotal Tracker #11060

Merged
merged 22 commits into from Apr 5, 2022

Conversation

bleonard
Copy link
Contributor

@bleonard bleonard commented Mar 11, 2022

What

Adds a source for Pivotal Tracker via this API
https://www.pivotaltracker.com/help/api/rest/v5

How

Python CDK

Recommended reading order

  1. source.py
New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added the area/connectors Connector related issues label Mar 11, 2022
@bleonard
Copy link
Contributor Author

(.venv) ➜  source-pivotal-tracker git:(source-pivotal-tracker) python -m pytest unit_tests
Test session starts (platform: darwin, Python 3.9.10, pytest 6.1.2, pytest-sugar 0.9.4)
cachedir: .pytest_cache
rootdir: /Users/brian/bleonard/airbyte, configfile: pytest.ini
plugins: sugar-0.9.4, mock-3.6.1, timeout-1.4.2
collecting ... 
 ../../github/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_source.py::test_check_connection ✓                11% █▎        
 ../../github/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_source.py::test_streams ✓                         22% ██▎       
 ../../github/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_streams.py::test_projects_stream ✓                33% ███▍      
 ../../github/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_streams.py::test_project_memberships_stream ✓     44% ████▌     
 ../../github/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_streams.py::test_activity_stream ✓                56% █████▋    
 ../../github/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_streams.py::test_labels_stream ✓                  67% ██████▋   
 ../../github/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_streams.py::test_releases_stream ✓                78% ███████▊  
 ../../github/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_streams.py::test_epics_stream ✓                   89% ████████▉ 
 ../../github/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_streams.py::test_stories_stream ✓                100% ██████████
===================================================================== warnings summary ======================================================================
../../../../../github/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_streams.py:9
  /Users/brian/github/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_streams.py:9: DeprecationWarning: Call to deprecated class HttpAuthenticator. (Use requests.auth.AuthBase instead) -- Deprecated since version 0.1.20.
    auth = PivotalAuthenticator("goodtoken")

airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_source.py::test_check_connection
airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_source.py::test_streams
  /Users/brian/bleonard/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/source_pivotal_tracker/source.py:124: DeprecationWarning: Call to deprecated class HttpAuthenticator. (Use requests.auth.AuthBase instead) -- Deprecated since version 0.1.20.
    return PivotalAuthenticator(token)

airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_source.py: 9 warnings
airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_streams.py: 7 warnings
  /Users/brian/github/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/.venv/lib/python3.9/site-packages/airbyte_cdk/sources/streams/http/http.py:42: DeprecationWarning: Call to deprecated class NoAuth. (Set `authenticator=None` instead) -- Deprecated since version 0.1.20.
    self._authenticator: HttpAuthenticator = NoAuth()

airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_source.py: 9 warnings
airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_streams.py: 7 warnings
  /Users/brian/github/airbyte/airbyte-integrations/connectors/source-pivotal-tracker/.venv/lib/python3.9/site-packages/deprecated/classic.py:173: DeprecationWarning: Call to deprecated class HttpAuthenticator. (Use requests.auth.AuthBase instead) -- Deprecated since version 0.1.20.
    return old_new1(cls, *args, **kwargs)

-- Docs: https://docs.pytest.org/en/stable/warnings.html

Results (0.22s):
       9 passed

@marcosmarxm marcosmarxm changed the title Source pivotal tracker 🎉 New Source: Pivotal Tracker Mar 11, 2022
@harshithmullapudi
Copy link
Contributor

Hey @bleonard thanks for the contribution

@harshithmullapudi harshithmullapudi self-assigned this Mar 14, 2022
@harshithmullapudi harshithmullapudi added waiting-for-cred Waiting for CI credentials and removed waiting-for-cred Waiting for CI credentials labels Mar 28, 2022
@github-actions github-actions bot added area/platform issues related to the platform area/protocol area/scheduler area/server area/worker Related to worker CDK Connector Development Kit kubernetes normalization labels Apr 5, 2022
@github-actions github-actions bot removed area/worker Related to worker area/api Related to the api area/server area/platform issues related to the platform normalization CDK Connector Development Kit area/scheduler area/frontend kubernetes area/protocol labels Apr 5, 2022
@timroes timroes removed the request for review from a team April 5, 2022 00:56
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bleonard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants