Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reporter App Monitoring. #11074

Merged
merged 3 commits into from
Mar 13, 2022
Merged

Reporter App Monitoring. #11074

merged 3 commits into from
Mar 13, 2022

Conversation

davinchia
Copy link
Contributor

@davinchia davinchia commented Mar 11, 2022 •
edited

What

Add a metric to monitor the monitoring app's rate of publishing metrics. Though this isn't perfect, it gives us some insight into whether metric publishing is okay or running into issues.

How

  • Add an anonymous function wrapper that publishes a count every time a metrics is emitted.
  • Add some more logs for visibility.

Recommended reading order

  1. ToEmit.java
  2. MetricsRegistry.java

馃毃 User Impact 馃毃

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 馃毃馃毃 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

davinchia
davinchia commented Mar 11, 2022
View reviewed changes
airbyte-commons/src/main/java/io/airbyte/commons/lang/Exceptions.java
@@ -41,22 +41,6 @@ public static void toRuntime(final Procedure voidCallable) {
castCheckedToRuntime(voidCallable, RuntimeException::new);
}

/**
Copy link
Contributor Author

@davinchia davinchia Mar 11, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realised we can combine this with the metric count callable and this is unnecessary.

benmoriceau
benmoriceau reviewed Mar 11, 2022
View reviewed changes
Copy link
Contributor

@benmoriceau benmoriceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just have a small commit around naming of the method.

airbyte-metrics/reporter/src/main/java/io/airbyte/metrics/reporter/ReporterApp.java Outdated Show resolved Hide resolved
airbyte-metrics/reporter/src/main/java/io/airbyte/metrics/reporter/ToEmit.java Outdated Show resolved Hide resolved
@davinchia davinchia temporarily deployed to more-secrets March 13, 2022 03:19 Inactive
@davinchia davinchia temporarily deployed to more-secrets March 13, 2022 03:19 Inactive
@davinchia davinchia merged commit af6c64d into master Mar 13, 2022
@davinchia davinchia deleted the davinchia/reporter-app-monitoring branch March 13, 2022 03:48
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Mar 13, 2022
Merged
terencecho pushed a commit that referenced this pull request Mar 14, 2022
@davinchia @terencecho
Reporter App Monitoring. (#11074)
348fc6e 
Add a metric to monitor the monitoring app's rate of publishing metrics. Though this isn't perfect, it gives us some insight into whether metric publishing is okay or running into issues.
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmoriceau benmoriceau benmoriceau left review comments

@jdpgrailsdev jdpgrailsdev Awaiting requested review from jdpgrailsdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davinchia @jdpgrailsdev @benmoriceau