🎉 Source Plaid: Fix 100 record limit and added start_date #11104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o Plaid connector
ehmadzubair
changed the title
|
|
github-actions
bot
added
the
area/documentation
|
Hey @ehmadzubair thanks for the contribution. Will review this in next few days |
marcosmarxm
reviewed
Mar 16, 2022
| @@ -75,6 +76,16 @@ def cursor_field(self) -> Union[str, List[str]]: | |||
| def get_updated_state(self, current_stream_state: MutableMapping[str, Any], latest_record: Mapping[str, Any]): | |||
| return {"date": latest_record.get("date")} | |||
|
|
|||
| def _get_transactions_response(self, start_date, end_date=datetime.datetime.utcnow().date(), offset=0): | |||
| from plaid.model.transactions_get_request_options import TransactionsGetRequestOptions | |||
There was a problem hiding this comment.
can you move the import to the beginning of the file?
marcosmarxm
requested changes
Mar 16, 2022
|
@marcosmarxm updated. |
harshithmullapudi
approved these changes
Mar 21, 2022
marcosmarxm
approved these changes
Apr 1, 2022
This was referenced Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #10252
Added Start Date to Plaid connector
How
start_datetospec.jsonand used it to fetch limited records.Recommended reading order
airbyte-integrations/connectors/source-plaid/source_plaid/spec.jsonairbyte-integrations/connectors/source-plaid/source_plaid/source.py🚨 User Impact 🚨
No breaking changes
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereTests
Unit
No Unit tests
Integration
Acceptance