Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frequency form #11159

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Fix frequency form #11159

merged 2 commits into from
Mar 16, 2022

Conversation

jamakase
Copy link
Contributor

@jamakase jamakase commented Mar 15, 2022 •
edited
Loading

What

Merges Frequency and Stream cards together according the designs. As a result the problem with fields reset is fixed ( #10993 )

image

@jamakase jamakase requested a review from a team as a code owner March 15, 2022 14:07
@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Mar 15, 2022
@jamakase jamakase temporarily deployed to more-secrets March 15, 2022 14:09 Inactive
@jamakase jamakase temporarily deployed to more-secrets March 15, 2022 14:09 Inactive
@jamakase jamakase self-assigned this Mar 15, 2022
@timroes
Copy link
Collaborator

timroes commented Mar 16, 2022

This does not fix the linked issue. Changing the schedule on any connection to Manual and save, then refresh the page will lead to the schedule being "every 24h". Also changing the input to manual and the destination namespace to something else and then save will immediately show that the schedule was set to "every 24h" instead.

@jamakase jamakase temporarily deployed to more-secrets March 16, 2022 12:31 Inactive
@jamakase jamakase temporarily deployed to more-secrets March 16, 2022 12:32 Inactive
@jamakase
Copy link
Contributor Author

This does not fix the linked issue. Changing the schedule on any connection to Manual and save, then refresh the page will lead to the schedule being "every 24h". Also changing the input to manual and the destination namespace to something else and then save will immediately show that the schedule was set to "every 24h" instead.

Indeed the root cause of the issue was different one. Pushed a fix.

timroes
timroes approved these changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome Linux locally. Fixes the described bug. Code LGTM

@jamakase jamakase merged commit da115ee into master Mar 16, 2022
@jamakase jamakase deleted the jamakase/fix-frequency-form branch March 16, 2022 13:07
@jamakase jamakase linked an issue Mar 16, 2022 that may be closed by this pull request
Replication frequency changes when source namespace change #10993
Closed
This was referenced Mar 16, 2022
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

Assignees

@jamakase jamakase

Labels
area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replication frequency changes when source namespace change
2 participants
@jamakase @timroes