Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Zendesk-Support: Implement OAuth2.0 #11162

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Mar 15, 2022

What

Resolving: #6285

How

  • edited source.py
  • edited spec.json
  • added server-side ZendeskSupportOAuthFlow.java class

🚨 User Impact 🚨

No impact expected.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@bazarnov bazarnov self-assigned this Mar 15, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Mar 15, 2022
@bazarnov bazarnov linked an issue Mar 15, 2022 that may be closed by this pull request
@codecov

This comment was marked as outdated.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Mar 15, 2022
@bazarnov bazarnov temporarily deployed to more-secrets March 15, 2022 15:23 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 15, 2022 15:23 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 15, 2022 15:35 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets March 15, 2022 15:35 Inactive
Copy link
Contributor

@annalvova05 annalvova05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please attach screenshots of the passed OAuth flow?

@bazarnov
Copy link
Collaborator Author

Could you please attach screenshots of the passed OAuth flow?

Sure.
Screenshot 2022-03-16 at 13 57 48
Screenshot 2022-03-16 at 13 58 49
Screenshot 2022-03-16 at 14 00 14
Screenshot 2022-03-16 at 14 00 36
Screenshot 2022-03-16 at 14 01 01

@bazarnov
Copy link
Collaborator Author

bazarnov commented Mar 16, 2022

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1992624323
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1992624323
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_zendesk_support/__init__.py       2      0   100%
source_zendesk_support/streams.py      268     81    70%
source_zendesk_support/source.py        45     25    44%
--------------------------------------------------------
TOTAL                                  315    106    66%

@bazarnov
Copy link
Collaborator Author

bazarnov commented Mar 16, 2022

/publish connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1992732858
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/1992732858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Zendesk Support: support oauth
2 participants