-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Zendesk Support: refactor TicketComments stream #11237
🐛 Source Zendesk Support: refactor TicketComments stream #11237
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11237 +/- ##
=========================================
Coverage ? 75.22%
=========================================
Files ? 3
Lines ? 331
Branches ? 0
=========================================
Hits ? 249
Misses ? 82
Partials ? 0 Continue to review full report at Codecov.
|
/test connector=connectors/source-zendesk-support
|
/test connector=connectors/source-zendesk-support
|
/test connector=connectors/source-zendesk-support
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small change requests
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-zendesk-support
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding those unit tests!~ Just a couple more requested and we should be good to go
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
Show resolved
Hide resolved
/test connector=connectors/source-zendesk-support
|
airbyte-integrations/connectors/source-zendesk-support/unit_tests/test_other.py
Outdated
Show resolved
Hide resolved
/publish connector=connectors/source-zendesk-support
|
What
Resolving: #8519
How
stream.py
by refactoring the TicketComments stream to fetch the data fromincremental/ticket_events
endpointTicketComments
streamschema
to include missing properties, after refactoring🚨 User Impact 🚨
No impact expected.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here