Skip to content

🐛 Fix the SQL Server Agent not querying in Chinese system - #11495

Merged
M. Marx (marcosmarxm) merged 5 commits into
airbytehq:masterfrom
deluxebear:bug/sqlserver
Apr 4, 2022
Merged

🐛 Fix the SQL Server Agent not querying in Chinese system#11495
M. Marx (marcosmarxm) merged 5 commits into
airbytehq:masterfrom
deluxebear:bug/sqlserver

Conversation

@deluxebear

@deluxebear eric (deluxebear) commented Mar 29, 2022

Copy link
Copy Markdown
Contributor

Fix the SQL Server Agent not querying in Chinese system

@CLAassistant

CLAassistant commented Mar 29, 2022 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added the area/connectors Connector related issues label Mar 29, 2022
@marcosmarxm

M. Marx (marcosmarxm) commented Mar 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

eric (@deluxebear) is it possible to share one example you have connecting to a Chinese MSSQL server? Can be a screenshot or showing test output.

tuliren
Liren Tu (tuliren) approved these changes Mar 31, 2022
View reviewed changes

@tuliren Liren Tu (tuliren) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that SQL Server uses localized service names. This approach is not scalable since it requires a different or condition for every language. But I cannot find a better way either.

Comment thread .../connectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlSource.java Outdated
@deluxebear @tuliren
Update airbyte-integrations/connectors/source-mssql/src/main/java/io/…
fb0a681 
…airbyte/integrations/source/mssql/MssqlSource.java

Co-authored-by: LiRen Tu <tuliren@gmail.com>
@marcosmarxm M. Marx (marcosmarxm) self-assigned this Mar 31, 2022
@deluxebear

eric (deluxebear) commented Mar 31, 2022

Copy link
Copy Markdown
Contributor Author

eric (@deluxebear) is it possible to share one example you have connecting to a Chinese MSSQL server? Can be a screenshot or showing test output.

image

@marcosmarxm

M. Marx (marcosmarxm) commented Mar 31, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

/test connector=connectors/source-mssql repo=deluxebear/airbyte

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2074226925
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2074226925
No Python unittests run

@marcosmarxm M. Marx (marcosmarxm) changed the title bug: Fix the SQL Server Agent not querying in Chinese system 🐛 Fix the SQL Server Agent not querying in Chinese system Apr 1, 2022
@deluxebear
eric (deluxebear) requested a review from a team as a code owner April 1, 2022 00:42
@github-actions github-actions Bot added area/api Related to the api area/documentation Improvements or additions to documentation area/frontend area/platform issues related to the platform area/scheduler area/server area/worker Related to worker kubernetes labels Apr 1, 2022
@github-actions github-actions Bot removed area/scheduler area/platform issues related to the platform labels Apr 1, 2022
@marcosmarxm

M. Marx (marcosmarxm) commented Apr 1, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

/publish connector=connectors/source-mssql repo=deluxebear/airbyte

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2074404530
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2074404530

@marcosmarxm

M. Marx (marcosmarxm) commented Apr 1, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

/publish connector=connectors/source-mssql-strict-encrypt repo=deluxebear/airbyte

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2074445008
✅ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2074445008

marcosmarxm
M. Marx (marcosmarxm) approved these changes Apr 4, 2022
View reviewed changes

@marcosmarxm M. Marx (marcosmarxm) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks eric (@deluxebear)

@marcosmarxm
M. Marx (marcosmarxm) merged commit 57fa793 into airbytehq:master Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@subodh1810 Subodh Chaturvedi (subodh1810) Awaiting requested review from subodh1810
2 more reviewers
@tuliren Liren Tu (tuliren) tuliren approved these changes
@marcosmarxm M. Marx (marcosmarxm) marcosmarxm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@marcosmarxm M. Marx (marcosmarxm)

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation community

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deluxebear @CLAassistant @marcosmarxm @tuliren @octavia-squidington-iii