Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix the SQL Server Agent not querying in Chinese system #11495

Merged
merged 5 commits into from
Apr 4, 2022
Merged

🐛 Fix the SQL Server Agent not querying in Chinese system #11495

merged 5 commits into from
Apr 4, 2022

Conversation

deluxebear
Copy link
Contributor

Fix the SQL Server Agent not querying in Chinese system

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Mar 29, 2022
@marcosmarxm
Copy link
Member

marcosmarxm commented Mar 30, 2022 •
edited
Loading

@deluxebear is it possible to share one example you have connecting to a Chinese MSSQL server? Can be a screenshot or showing test output.

tuliren
tuliren approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that SQL Server uses localized service names. This approach is not scalable since it requires a different or condition for every language. But I cannot find a better way either.

.../connectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlSource.java Outdated Show resolved Hide resolved
@deluxebear @tuliren
Update airbyte-integrations/connectors/source-mssql/src/main/java/io/…
fb0a681 
…airbyte/integrations/source/mssql/MssqlSource.java

Co-authored-by: LiRen Tu <tuliren@gmail.com>
@marcosmarxm marcosmarxm self-assigned this Mar 31, 2022
@deluxebear
Copy link
Contributor Author

@deluxebear is it possible to share one example you have connecting to a Chinese MSSQL server? Can be a screenshot or showing test output.

image

@marcosmarxm
Copy link
Member

marcosmarxm commented Mar 31, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mssql repo=deluxebear/airbyte

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2074226925
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2074226925
No Python unittests run

@marcosmarxm marcosmarxm changed the title bug: Fix the SQL Server Agent not querying in Chinese system 🐛 Fix the SQL Server Agent not querying in Chinese system Apr 1, 2022
@deluxebear deluxebear requested a review from a team as a code owner April 1, 2022 00:42
@github-actions github-actions bot added area/api Related to the api area/documentation Improvements or additions to documentation area/frontend area/platform issues related to the platform area/scheduler area/server area/worker Related to worker kubernetes labels Apr 1, 2022
@github-actions github-actions bot removed area/scheduler area/platform issues related to the platform labels Apr 1, 2022
@marcosmarxm
Copy link
Member

marcosmarxm commented Apr 1, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mssql repo=deluxebear/airbyte

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2074404530
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2074404530

@marcosmarxm
Copy link
Member

marcosmarxm commented Apr 1, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mssql-strict-encrypt repo=deluxebear/airbyte

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2074445008
✅ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2074445008

marcosmarxm
marcosmarxm approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @deluxebear

@marcosmarxm marcosmarxm merged commit 57fa793 into airbytehq:master Apr 4, 2022
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliren tuliren tuliren approved these changes

@marcosmarxm marcosmarxm marcosmarxm approved these changes

@subodh1810 subodh1810 Awaiting requested review from subodh1810

Assignees

@marcosmarxm marcosmarxm

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deluxebear @CLAassistant @marcosmarxm @tuliren @octavia-squidington-iii