Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Mixpanel: Enhance streams to incremental #11501

Merged
merged 9 commits into from
May 2, 2022
Merged

🎉 Source Mixpanel: Enhance streams to incremental #11501

merged 9 commits into from
May 2, 2022

Conversation

itaseskii
Copy link
Contributor

@itaseskii itaseskii commented Mar 29, 2022

What

Add incremental support to the following streams: Engage, Cohorts and Cohort Members.

Closes #12209.

How

Source and user define cursors

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added the area/connectors Connector related issues label Mar 29, 2022
@marcosmarxm
Copy link
Member

@itaseskii can you run ./gradlew format some missing headers and formatting stuff.

@marcosmarxm marcosmarxm self-assigned this Mar 30, 2022
@itaseskii
Copy link
Contributor Author

@itaseskii can you run ./gradlew format some missing headers and formatting stuff.

@marcosmarxm I have some local python related issues when running ./gradlew format. can this be reviewed without it? i will fix it in the meantime :)

@itaseskii
Copy link
Contributor Author

@itaseskii can you run ./gradlew format some missing headers and formatting stuff.

@marcosmarxm I have ran ./gradlew format locally and all the formatting changes I am getting are

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   airbyte-cdk/python/airbyte_cdk/models/airbyte_protocol.py
        modified:   airbyte-integrations/bases/airbyte-protocol/airbyte_protocol/models/airbyte_protocol.py
	modified:   airbyte-integrations/connectors/destination-bigquery/src/main/java/io/airbyte/integrations/destination/bigquery/BigQueryDestination.java
	modified:   airbyte-integrations/connectors/destination-snowflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDatabase.java
	modified:   airbyte-integrations/connectors/destination-snowflake/src/main/resources/spec.json
	modified:   airbyte-integrations/connectors/source-bamboo-hr/source_bamboo_hr/schemas/custom_reports_stream.json

None of them are related to the Mixpanel stream.

@marcosmarxm
Copy link
Member

/test connector=connectors/source-mixpanel

@marcosmarxm
Copy link
Member

@itaseskii can you solve the conflict so I can test/mrge the contribution?

@itaseskii
Copy link
Contributor Author

@itaseskii can you solve the conflict so I can test/mrge the contribution?

Hey @marcosmarxm I have resolved the conflicts.

@marcosmarxm
Copy link
Member

marcosmarxm commented May 2, 2022

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2259505310
❌ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/2259505310
🐛 https://gradle.com/s/pn7p4s4rkbk4q

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label May 2, 2022
@marcosmarxm marcosmarxm temporarily deployed to more-secrets May 2, 2022 21:33 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets May 2, 2022 21:33 Inactive
@marcosmarxm marcosmarxm merged commit aab4f34 into airbytehq:master May 2, 2022
suhomud pushed a commit that referenced this pull request May 23, 2022
* enhance streams to incremental

* revert file structure

* 11501

* add engage

* doc and bump connector version

Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community sponsored
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Mixpanel: Incremental Sync
3 participants