-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store the identifier of the catalog of the source when creating a new connection #11610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundito
reviewed
Apr 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
frontend LGTM ✅
21ef33f
to
d6adc26
Compare
d6adc26
to
7d3ebfa
Compare
edmundito
approved these changes
Apr 20, 2022
7d3ebfa
to
451f89c
Compare
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
… connection (#11610) * Store source_catalog_id when creating a connection * Set sourceCatalogId when creating a new connection * Fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/api
Related to the api
area/documentation
Improvements or additions to documentation
area/platform
issues related to the platform
area/server
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9901
Modify the backend code to return the identifier of the source catalog when a source is created or selected to build a connection.
Modify the front-end to send that information back when a connection is created.
That information is then stored in the
sourceCatalogId
column of the database.