Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the identifier of the catalog of the source when creating a new connection #11610

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

malikdiarra
Copy link
Contributor

@malikdiarra malikdiarra commented Mar 31, 2022

closes #9901

Modify the backend code to return the identifier of the source catalog when a source is created or selected to build a connection.
Modify the front-end to send that information back when a connection is created.
That information is then stored in the sourceCatalogId column of the database.

@malikdiarra malikdiarra requested a review from a team as a code owner March 31, 2022 05:03
@github-actions github-actions bot added area/api Related to the api area/documentation Improvements or additions to documentation area/frontend area/platform issues related to the platform area/server labels Mar 31, 2022
Copy link
Contributor

@edmundito edmundito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontend LGTM ✅

Base automatically changed from malik/fix-actor-catalog to master April 14, 2022 19:56
@malikdiarra malikdiarra reopened this Apr 14, 2022
@malikdiarra malikdiarra temporarily deployed to more-secrets April 16, 2022 00:39 Inactive
@malikdiarra malikdiarra temporarily deployed to more-secrets April 16, 2022 00:39 Inactive
@malikdiarra malikdiarra temporarily deployed to more-secrets April 19, 2022 22:19 Inactive
@malikdiarra malikdiarra temporarily deployed to more-secrets April 19, 2022 22:19 Inactive
@malikdiarra malikdiarra temporarily deployed to more-secrets April 21, 2022 16:49 Inactive
@malikdiarra malikdiarra temporarily deployed to more-secrets April 21, 2022 16:49 Inactive
@malikdiarra malikdiarra temporarily deployed to more-secrets April 21, 2022 17:09 Inactive
@malikdiarra malikdiarra temporarily deployed to more-secrets April 21, 2022 17:09 Inactive
@malikdiarra malikdiarra temporarily deployed to more-secrets April 21, 2022 20:02 Inactive
@malikdiarra malikdiarra temporarily deployed to more-secrets April 21, 2022 20:02 Inactive
@malikdiarra malikdiarra merged commit 82e31c7 into master Apr 21, 2022
@malikdiarra malikdiarra deleted the malik/discover-schema branch April 21, 2022 22:31
suhomud pushed a commit that referenced this pull request May 23, 2022
… connection (#11610)

* Store source_catalog_id when creating a connection

* Set sourceCatalogId when creating a new connection

* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When setting up a connection, track what version of the schema was used.
3 participants