Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish connector command now auto bumps version #11712

Merged
merged 25 commits into from
Apr 5, 2022
Merged

Conversation

Phlair
Copy link
Contributor

@Phlair Phlair commented Apr 4, 2022

What

solving #11564

How

  • Using yq to look at and update the relevant definitions yaml with the new version
  • running ./gradlew :airbyte-config:init:processResources generate seed specs
  • pushing changes back into the origin branch of the PR using the Octavia account

Notes

  • The version bumps to destination-dev-null and source-apify-dataset were just dummy bumps to test the publish changes.

  • I played around with automatically bumping the changelog in the connector's docs but decided against it because:

    • changelogs aren't consistent (sometimes they don't exist, sometimes there is more than one changelog in the same doc)
    • rather than a replace, this is a line addition, meaning we could end up with double entry if the developer has manually updated the changelog (EDIT: this could be avoided pretty easily with an extra check)

@Phlair Phlair changed the title George/auto bumperrr Publish connector command now auto bumps version Apr 4, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Apr 4, 2022
@Phlair Phlair temporarily deployed to more-secrets April 4, 2022 22:42 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 4, 2022 22:42 Inactive
@Phlair
Copy link
Contributor Author

Phlair commented Apr 4, 2022

test

🕑 connectors/source-apify-dataset https://github.com/airbytehq/airbyte/actions/runs/2092996269
❌ Failed to publish connectors/source-apify-dataset
❌ Couldn't auto-bump version for connectors/source-apify-dataset
🕑 connectors/source-apify-dataset https://github.com/airbytehq/airbyte/actions/runs/2092996269
🚀 Successfully published connectors/source-apify-dataset
🚀 Auto-bumped version for connectors/source-apify-dataset
✅ connectors/source-apify-dataset https://github.com/airbytehq/airbyte/actions/runs/2092996269

@Phlair Phlair temporarily deployed to more-secrets April 4, 2022 23:07 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 4, 2022 23:07 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 4, 2022 23:08 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 4, 2022 23:15 Inactive
@CLAassistant
Copy link

CLAassistant commented Apr 4, 2022

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 4, 2022 23:25 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 4, 2022 23:25 Inactive
@Phlair Phlair requested a review from alafanechere April 4, 2022 23:54
@Phlair
Copy link
Contributor Author

Phlair commented Apr 5, 2022

testing with auto-bump flag true

🕑 connectors/source-apify-dataset https://github.com/airbytehq/airbyte/actions/runs/2093334559
🚀 Successfully published connectors/source-apify-dataset
🚀 Auto-bumped version for connectors/source-apify-dataset
✅ connectors/source-apify-dataset https://github.com/airbytehq/airbyte/actions/runs/2093334559

@Phlair Phlair temporarily deployed to more-secrets April 5, 2022 00:45 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 5, 2022 00:45 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 5, 2022 00:46 Inactive
@@ -42,7 +42,7 @@
- name: Apify Dataset
sourceDefinitionId: 47f17145-fe20-4ef5-a548-e29b048adf84
dockerRepository: airbyte/source-apify-dataset
dockerImageTag: 0.1.3
dockerImageTag: 0.1.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be reverted before we merge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been publishing the version bumps while testing, do you think it's worth reverting and removing the published bumps?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah should we just add that info in the changelog just so we know what these versions are?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good point, will add that

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 5, 2022 00:56 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 5, 2022 00:56 Inactive
@Phlair Phlair marked this pull request as draft April 5, 2022 16:10
@Phlair Phlair marked this pull request as ready for review April 5, 2022 16:11
@Phlair Phlair requested a review from sherifnada April 5, 2022 17:31
@Phlair Phlair temporarily deployed to more-secrets April 5, 2022 17:37 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 5, 2022 17:37 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 5, 2022 17:45 Inactive
@Phlair Phlair temporarily deployed to more-secrets April 5, 2022 17:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants