Source Amazon Ads: Update fields in source-connectors specifications #11730

grubberr · 2022-04-05T14:40:21Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-04-05T14:44:11Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2096903349
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2096903349
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          16      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/common.py                                  78      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            25      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          199      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               657      7    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 22 passed, 1 skipped in 15.53s ========================

docs/integrations/sources/amazon-ads.md

codecov · 2022-04-05T14:53:43Z

Codecov Report

❗ No coverage uploaded for pull request base (master@9ee1f79). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 08c55ed differs from pull request most recent head 691cd56. Consider uploading reports for the commit 691cd56 to get more accurate results

@@            Coverage Diff            @@
##             master   #11730   +/-   ##
=========================================
  Coverage          ?   98.79%           
=========================================
  Files             ?       22           
  Lines             ?      663           
  Branches          ?        0           
=========================================
  Hits              ?      655           
  Misses            ?        8           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee1f79...691cd56. Read the comment docs.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-04-21T06:08:20Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2200037163
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2200037163
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          17      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            28      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  77      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          200      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               661      8    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 23 passed, 1 skipped in 223.64s (0:03:43) ===================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-04-22T06:50:45Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2206190347
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2206190347
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          17      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            28      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  77      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          200      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               661      8    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 23 passed, 1 skipped in 221.36s (0:03:41) ===================

misteryeo

I didn't hear back from you on Slack @grubberr - can you make sure to respond there about how we're automatically adding the asterisks and why it's not consistent across the fields?

Approving this based on what's been shown in the screenshot.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

…d (2) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

… required (2)" This reverts commit 089dbec.

… required" This reverts commit de6dbab.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-04-28T05:57:23Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2237389913
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2237389913
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          19      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            28      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  77      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          200      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               663      8    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 23 passed, 1 skipped in 357.28s (0:05:57) ===================

grubberr · 2022-04-28T06:20:17Z

/publish connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2237479707
🚀 Successfully published connectors/source-amazon-ads
🚀 Auto-bumped version for connectors/source-amazon-ads
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2237479707

…11730) * Update fields in source-connectors specifications Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Update fields in source-connectors specifications

afbb3a0

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr self-assigned this Apr 5, 2022

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 5, 2022

grubberr temporarily deployed to more-secrets April 5, 2022 14:42 Inactive

grubberr linked an issue Apr 5, 2022 that may be closed by this pull request

Update fields in source-connectors specifications: amazon-ads #8916

Closed

grubberr requested a review from igrankova April 5, 2022 14:45

igrankova suggested changes Apr 5, 2022

View reviewed changes

docs/integrations/sources/amazon-ads.md Outdated Show resolved Hide resolved

fix PR link

e2ff115

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr requested a review from igrankova April 5, 2022 14:55

igrankova approved these changes Apr 5, 2022

View reviewed changes

grubberr temporarily deployed to more-secrets April 5, 2022 14:56 Inactive

grubberr temporarily deployed to more-secrets April 5, 2022 14:57 Inactive

igrankova requested review from misteryeo and removed request for misteryeo April 5, 2022 14:57

grubberr added 3 commits April 20, 2022 17:46

Merge branch 'master' into grubberr/8916-source-amazon-ads

0ab7cd1

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

improve labels

539c62e

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

bump version

cd348c0

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr requested a review from misteryeo April 20, 2022 22:07

grubberr added 2 commits April 21, 2022 07:51

Merge branch 'master' into grubberr/8916-source-amazon-ads

6217d1f

add order to spec

c2e2410

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr added 4 commits April 22, 2022 08:46

Merge branch 'master' into grubberr/8916-source-amazon-ads

389418e

update requirements fields in amazon-ads.md file

5fbfa9e

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

re-order fields

b46f1ef

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

amazon-ads.md updated

8fa3f67

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

bleonard added the team/connectors-python label Apr 22, 2022

misteryeo approved these changes Apr 26, 2022

View reviewed changes

grubberr added 8 commits April 27, 2022 12:04

Merge branch 'master' into grubberr/8916-source-amazon-ads

9c4597b

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

bump version 0.1.6 -> 0.1.7

1c05a04

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Merge branch 'master' into grubberr/8916-source-amazon-ads

699efae

region, report_wait_timeout, report_generation_max_retries is required

de6dbab

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

region, report_wait_timeout, report_generation_max_retries is require…

089dbec

…d (2) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Revert "region, report_wait_timeout, report_generation_max_retries is…

03b0cf1

… required (2)" This reverts commit 089dbec.

Revert "region, report_wait_timeout, report_generation_max_retries is…

d11fc25

… required" This reverts commit de6dbab.

code format

08c55ed

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

auto-bump connector version

691cd56

grubberr merged commit 42a58b0 into master Apr 28, 2022

grubberr deleted the grubberr/8916-source-amazon-ads branch April 28, 2022 06:36

octavia-squidington-iii temporarily deployed to more-secrets April 28, 2022 06:37 Inactive

This was referenced Apr 28, 2022

Bump Airbyte version from 0.36.4-alpha to 0.36.5-alpha #12448

Merged

Bump Airbyte version from 0.36.4-alpha to 0.36.5-alpha #12453

Closed

suhomud pushed a commit that referenced this pull request May 23, 2022

Source Amazon Ads: Update fields in source-connectors specifications (#…

d361d02

…11730) * Update fields in source-connectors specifications Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Amazon Ads: Update fields in source-connectors specifications #11730

Source Amazon Ads: Update fields in source-connectors specifications #11730

grubberr commented Apr 5, 2022 •

edited

Loading

grubberr commented Apr 5, 2022 •

edited by github-actions bot

Loading

codecov bot commented Apr 5, 2022 •

edited

Loading

grubberr commented Apr 21, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 22, 2022 •

edited by github-actions bot

Loading

misteryeo left a comment

grubberr commented Apr 28, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 28, 2022 •

edited by github-actions bot

Loading

Source Amazon Ads: Update fields in source-connectors specifications #11730

Source Amazon Ads: Update fields in source-connectors specifications #11730

Conversation

grubberr commented Apr 5, 2022 • edited Loading

What

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

grubberr commented Apr 5, 2022 • edited by github-actions bot Loading

codecov bot commented Apr 5, 2022 • edited Loading

Codecov Report

grubberr commented Apr 21, 2022 • edited by github-actions bot Loading

grubberr commented Apr 22, 2022 • edited by github-actions bot Loading

misteryeo left a comment

Choose a reason for hiding this comment

grubberr commented Apr 28, 2022 • edited by github-actions bot Loading

grubberr commented Apr 28, 2022 • edited by github-actions bot Loading

grubberr commented Apr 5, 2022 •

edited

Loading

grubberr commented Apr 5, 2022 •

edited by github-actions bot

Loading

codecov bot commented Apr 5, 2022 •

edited

Loading

grubberr commented Apr 21, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 22, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 28, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 28, 2022 •

edited by github-actions bot

Loading