Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart: add JOB_KUBE_ANNOTATIONS andJOB_KUBE_NODE_SELECTORS #11754

Merged
merged 5 commits into from
Apr 20, 2022
Merged

Helm Chart: add JOB_KUBE_ANNOTATIONS andJOB_KUBE_NODE_SELECTORS #11754

merged 5 commits into from
Apr 20, 2022

Conversation

ufou
Copy link
Contributor

@ufou ufou commented Apr 6, 2022

What

This PR fixes the helm chart in charts/airbyte by allowing JOB_KUBE_ANNOTATIONS and JOB_KUBE_NODE_SELECTORS to be optional, issue here: #11753

How

Add a section to the helm chart values, env configmap and worker deployment which optionally handles the JOB_KUBE_ANNOTATIONS and JOB_KUBE_NODE_SELECTORS env vars, also add a helper function to convert a map object to a comma separated list

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨
AFAIK there are no breaking changes

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@CLAassistant
Copy link

CLAassistant commented Apr 6, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@marcosmarxm
Copy link
Member

@ufou the PR is still a draft, changes to ready to review when is done. Also solve the conflicts and comments made by @auyer

@marcosmarxm marcosmarxm self-assigned this Apr 13, 2022
@krzysdabro
Copy link
Contributor

Hi @ufou, can you also add JOB_KUBE_TOLERATIONS?

@ufou
Copy link
Contributor Author

ufou commented Apr 19, 2022

Hi @ufou, can you also add JOB_KUBE_TOLERATIONS?

I've added this too

@ufou ufou marked this pull request as ready for review April 19, 2022 10:21
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ufou

@marcosmarxm marcosmarxm changed the title [helm chart] only add JOB_KUBE_ANNOTATIONS/JOB_KUBE_NODE_SELECTORS when set via values Helm Chart: add JOB_KUBE_ANNOTATIONS andJOB_KUBE_NODE_SELECTORS Apr 20, 2022
@marcosmarxm marcosmarxm merged commit 1e996c4 into airbytehq:master Apr 20, 2022
suhomud pushed a commit that referenced this pull request May 23, 2022
* [helm chart] only add JOB_KUBE_ANNOTATIONS/JOB_KUBE_NODE_SELECTORS when set via values

* fix wording on values

* fix JOB_KUBE_NODE_SELECTORS, add JOB_KUBE_TOLERATIONS

Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform community kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants