Source Facebook: upgrade SDK version to 13 #11761

marcosmarxm · 2022-04-06T16:40:53Z

What

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

marcosmarxm · 2022-04-06T16:43:09Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2103810575
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2103810575
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              33      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/api.py                              101     13    87%
source_facebook_marketing/streams/base_streams.py             127     27    79%
source_facebook_marketing/streams/common.py                    41     13    68%
source_facebook_marketing/streams/streams.py                   97     32    67%
source_facebook_marketing/source.py                            35     13    63%
source_facebook_marketing/streams/base_insight_streams.py     129     54    58%
source_facebook_marketing/streams/async_job.py                204    128    37%
source_facebook_marketing/streams/async_job_manager.py         74     56    24%
-------------------------------------------------------------------------------
TOTAL                                                         845    336    60%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/async_job.py                204      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              33      0   100%
source_facebook_marketing/source.py                            35      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/streams/common.py                    41      1    98%
source_facebook_marketing/streams/async_job_manager.py         74      3    96%
source_facebook_marketing/api.py                              101     10    90%
source_facebook_marketing/streams/base_insight_streams.py     129     13    90%
source_facebook_marketing/streams/streams.py                   97     22    77%
source_facebook_marketing/streams/base_streams.py             127     30    76%
-------------------------------------------------------------------------------
TOTAL                                                         845     79    91%

alafanechere

LGTM if the tests are passing!

codecov · 2022-04-06T16:59:38Z

Codecov Report

❗ No coverage uploaded for pull request base (master@2d0cc78). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11761   +/-   ##
=========================================
  Coverage          ?   90.59%           
=========================================
  Files             ?       11           
  Lines             ?      840           
  Branches          ?        0           
=========================================
  Hits              ?      761           
  Misses            ?       79           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0cc78...26dccf4. Read the comment docs.

marcosmarxm · 2022-04-06T17:06:35Z

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2103934000
❌ Failed to publish connectors/source-facebook-marketing
❌ Couldn't auto-bump version for connectors/source-facebook-marketing

marcosmarxm · 2022-04-06T18:44:15Z

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2104420252
❌ Failed to publish connectors/source-facebook-marketing
❌ Couldn't auto-bump version for connectors/source-facebook-marketing

marcosmarxm · 2022-04-06T19:35:45Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2104676891
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2104676891
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              33      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/api.py                              101     13    87%
source_facebook_marketing/streams/base_streams.py             127     27    79%
source_facebook_marketing/streams/common.py                    41     13    68%
source_facebook_marketing/streams/streams.py                   97     32    67%
source_facebook_marketing/source.py                            35     13    63%
source_facebook_marketing/streams/base_insight_streams.py     129     54    58%
source_facebook_marketing/streams/async_job.py                204    128    37%
source_facebook_marketing/streams/async_job_manager.py         74     56    24%
-------------------------------------------------------------------------------
TOTAL                                                         845    336    60%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/async_job.py                204      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              33      0   100%
source_facebook_marketing/source.py                            35      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/streams/common.py                    41      1    98%
source_facebook_marketing/streams/async_job_manager.py         74      3    96%
source_facebook_marketing/api.py                              101     10    90%
source_facebook_marketing/streams/base_insight_streams.py     129     13    90%
source_facebook_marketing/streams/streams.py                   97     22    77%
source_facebook_marketing/streams/base_streams.py             127     30    76%
-------------------------------------------------------------------------------
TOTAL                                                         845     79    91%

marcosmarxm · 2022-04-06T20:08:01Z

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2104827026
🚀 Successfully published connectors/source-facebook-marketing
❌ Couldn't auto-bump version for connectors/source-facebook-marketing

marcosmarxm · 2022-04-06T20:40:10Z

Published here: https://hub.docker.com/layers/source-facebook-marketing/airbyte/source-facebook-marketing/0.2.42/images/sha256-3a6fe9f6f7bd5274de946008d6a4788bc893b0c9d1f1660c13805871c0f3029d?context=explore

bumpp fb bussiness sdk version

22a0559

marcosmarxm requested a review from alafanechere April 6, 2022 16:40

update fb doc

26dccf4

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 6, 2022

marcosmarxm temporarily deployed to more-secrets April 6, 2022 16:43 Inactive

alafanechere approved these changes Apr 6, 2022

View reviewed changes

marcosmarxm temporarily deployed to more-secrets April 6, 2022 21:27 Inactive

marcosmarxm merged commit e5007be into master Apr 6, 2022

marcosmarxm deleted the marcos/bump-facebook-sdk-version-13 branch April 6, 2022 21:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Facebook: upgrade SDK version to 13 #11761

Source Facebook: upgrade SDK version to 13 #11761

marcosmarxm commented Apr 6, 2022 •

edited

Loading

marcosmarxm commented Apr 6, 2022 •

edited by github-actions bot

Loading

alafanechere left a comment

codecov bot commented Apr 6, 2022

marcosmarxm commented Apr 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 6, 2022

Source Facebook: upgrade SDK version to 13 #11761

Source Facebook: upgrade SDK version to 13 #11761

Conversation

marcosmarxm commented Apr 6, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

marcosmarxm commented Apr 6, 2022 • edited by github-actions bot Loading

alafanechere left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 6, 2022

Codecov Report

marcosmarxm commented Apr 6, 2022 • edited by github-actions bot Loading

marcosmarxm commented Apr 6, 2022 • edited by github-actions bot Loading

marcosmarxm commented Apr 6, 2022 • edited by github-actions bot Loading

marcosmarxm commented Apr 6, 2022 • edited by github-actions bot Loading

marcosmarxm commented Apr 6, 2022

marcosmarxm commented Apr 6, 2022 •

edited

Loading

marcosmarxm commented Apr 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 6, 2022 •

edited by github-actions bot

Loading