Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Zendesk Support: added articles and sections streams #11960

Conversation

erichartono
Copy link

What

Added new Articles and Sections on Zendesk Support

How

  • edited source.py
  • edited streams.py
  • added integration tests

🚨 User Impact 🚨

No impact expected

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

(.venv) 192-168-1-101:source-zendesk-support eric.hartono$ python -m pytest unit_tests
Test session starts (platform: darwin, Python 3.10.4, pytest 6.2.5, pytest-sugar 0.9.4)
cachedir: .pytest_cache
rootdir: /Users/eric.hartono/Projects/airbyte, configfile: pytest.ini
plugins: sugar-0.9.4, requests-mock-1.9.3, timeout-1.4.2
collecting ...
airbyte-integrations/connectors/source-zendesk-support/unit_tests/test_futures.py::test_proper_number_of_future_requests_generated[1000-100-10] βœ“ 5% β–Œ
airbyte-integrations/connectors/source-zendesk-support/unit_tests/test_futures.py::test_proper_number_of_future_requests_generated[1000-10-100] βœ“ 9% β–‰
airbyte-integrations/connectors/source-zendesk-support/unit_tests/test_futures.py::test_proper_number_of_future_requests_generated[0-100-0] βœ“ 14% β–ˆβ–
airbyte-integrations/connectors/source-zendesk-support/unit_tests/test_futures.py::test_proper_number_of_future_requests_generated[1-100-1] βœ“ 18% β–ˆβ–Š
airbyte-integrations/connectors/source-zendesk-support/unit_tests/test_futures.py::test_proper_number_of_future_requests_generated[101-100-2] βœ“ 23% β–ˆβ–ˆβ–
airbyte-integrations/connectors/source-zendesk-support/unit_tests/test_futures.py::test_parse_future_records[10-10-10] βœ“ 27% β–ˆβ–ˆβ–Š
airbyte-integrations/connectors/source-zendesk-support/unit_tests/test_futures.py::test_parse_future_records[10-100-10] βœ“ 32% β–ˆβ–ˆβ–ˆβ–Ž
airbyte-integrations/connectors/source-zendesk-support/unit_tests/test_futures.py::test_parse_future_records[10-10-0] βœ“ 36% β–ˆβ–ˆβ–ˆβ–‹
airbyte-integrations/connectors/source-zendesk-support/unit_tests/test_futures.py::test_read_records[1000-100-10-True] βœ“ 41% β–ˆβ–ˆβ–ˆβ–ˆβ–
airbyte-integrations/connectors/source-zendesk-support/unit_tests/test_futures.py::test_read_records[1000-10-100-True] βœ“ 45% β–ˆβ–ˆβ–ˆβ–ˆβ–‹
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_str2datetime βœ“ 50% β–ˆβ–ˆβ–ˆβ–ˆβ–ˆ
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_datetime2str βœ“ 55% β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–Œ
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_str2unixtime βœ“ 59% β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–‰
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_check_start_time_param βœ“ 64% β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_parse_next_page_number βœ“ 68% β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–Š
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_next_page_token βœ“ 73% β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_check_stream_state[state present] βœ“ 77% β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–Š
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_check_stream_state[empty string in state] βœ“ 82% β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–Ž
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_check_stream_state[state is None] βœ“ 86% β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–‹
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_check_stream_state[cursor is not in the state object] βœ“ 91% β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_request_params βœ“ 95% β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–‹
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py::test_parse_response βœ“ 100% β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆ
=============================================================================================================================== warnings summary ===============================================================================================================================
.venv/lib/python3.10/site-packages/airbyte_cdk/sources/utils/transform.py:12
/Users/eric.hartono/Projects/airbyte/airbyte-integrations/connectors/source-zendesk-support/.venv/lib/python3.10/site-packages/airbyte_cdk/sources/utils/transform.py:12: DeprecationWarning: Call to deprecated class AirbyteLogger. (Use logging.getLogger('airbyte') instead) -- Deprecated since version 0.1.47.
logger = AirbyteLogger()

.venv/lib/python3.10/site-packages/airbyte_cdk/sources/streams/http/rate_limiting.py:19
/Users/eric.hartono/Projects/airbyte/airbyte-integrations/connectors/source-zendesk-support/.venv/lib/python3.10/site-packages/airbyte_cdk/sources/streams/http/rate_limiting.py:19: DeprecationWarning: Call to deprecated class AirbyteLogger. (Use logging.getLogger('airbyte') instead) -- Deprecated since version 0.1.47.
logger = AirbyteLogger()

.venv/lib/python3.10/site-packages/airbyte_cdk/utils/event_timing.py:13
/Users/eric.hartono/Projects/airbyte/airbyte-integrations/connectors/source-zendesk-support/.venv/lib/python3.10/site-packages/airbyte_cdk/utils/event_timing.py:13: DeprecationWarning: Call to deprecated class AirbyteLogger. (Use logging.getLogger('airbyte') instead) -- Deprecated since version 0.1.47.
logger = AirbyteLogger()

.venv/lib/python3.10/site-packages/airbyte_cdk/sources/streams/http/http.py:43: 1 warning
airbyte-integrations/connectors/source-zendesk-support/unit_tests/test_futures.py: 10 warnings
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py: 4 warnings
/Users/eric.hartono/Projects/airbyte/airbyte-integrations/connectors/source-zendesk-support/.venv/lib/python3.10/site-packages/airbyte_cdk/sources/streams/http/http.py:43: DeprecationWarning: Call to deprecated class NoAuth. (Set authenticator=None instead) -- Deprecated since version 0.1.20.
self._authenticator: HttpAuthenticator = NoAuth()

.venv/lib/python3.10/site-packages/deprecated/classic.py:173: 1 warning
airbyte-integrations/connectors/source-zendesk-support/unit_tests/test_futures.py: 10 warnings
airbyte-integrations/connectors/source-zendesk-support/unit_tests/unit_test.py: 4 warnings
/Users/eric.hartono/Projects/airbyte/airbyte-integrations/connectors/source-zendesk-support/.venv/lib/python3.10/site-packages/deprecated/classic.py:173: DeprecationWarning: Call to deprecated class HttpAuthenticator. (Use requests.auth.AuthBase instead) -- Deprecated since version 0.1.20.
return old_new1(cls, *args, **kwargs)

-- Docs: https://docs.pytest.org/en/stable/warnings.html

Results (86.83s):
22 passed

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

βœ… erichartono
❌ Eric Hartono


Eric Hartono seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 13, 2022
@marcosmarxm marcosmarxm changed the title Added articles and sections Source Zendesk Support: added articles and sections streams Apr 14, 2022
@harshithmullapudi
Copy link
Contributor

Hey @erichartono looks like the first commits are from different user can you fix those commits so that CLA doesn't throw any error

@harshithmullapudi harshithmullapudi self-assigned this Apr 19, 2022
@harshithmullapudi
Copy link
Contributor

Hey, @erichartono have you got time to fix the above thing?

@harshithmullapudi
Copy link
Contributor

Hey closing this PR feel free to open it back once we have the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation blocked community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants