-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Twilio: use Retry-After header for backoff #12157
Source Twilio: use Retry-After header for backoff #12157
Conversation
618403e
to
87ad9db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you @gvillafanetapia for these changes. I made a minor suggestion.
Could you please update the changelog in docs/integrations/sources/twilio.md
and bump the connector version in:
airbyte-integrations/connectors/source-twilio/Dockerfile
airbyte-config/init/src/main/resources/seed/source_definitions.yaml
airbyte-config/init/src/main/resources/seed/source_specs.yaml
airbyte-integrations/connectors/source-twilio/source_twilio/streams.py
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-twilio
|
…reams.py Co-authored-by: Augustin <augustin@airbyte.io>
@gvillafanetapia The tests are not passing because of some updates that needed to be made on this connector. I did the updates here #12183 and will re-run the tests here once it's merged. |
Hey @gvillafanetapia, I merged #12183 . Do you mind:
|
/publish connector=connectors/source-twilio auto-bump-version=false
|
Thank you @gvillafanetapia for the improvement! 🙏 |
What
Describe what the change is solving
Source Twilio:
requirements.txt
needed for devRetry-After
header returned by Twilio APIHow
Describe the solution
Overrides
backoff_time
method inTwilioStream
class and returnsRetry-After
if exists.Recommended reading order
airbyte-integrations/connectors/source-twilio/source_twilio/streams.py
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
No breaking changes
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Acceptance
Put your acceptance tests output here.