Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Twilio: use Retry-After header for backoff #12157

Merged
merged 6 commits into from
Apr 22, 2022

Conversation

gvillafanetapia
Copy link
Contributor

@gvillafanetapia gvillafanetapia commented Apr 19, 2022

What

Describe what the change is solving

Source Twilio:

How

Describe the solution

Overrides backoff_time method in TwilioStream class and returns Retry-After if exists.

Recommended reading order

  1. airbyte-integrations/connectors/source-twilio/source_twilio/streams.py

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

No breaking changes

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Acceptance

Put your acceptance tests output here.

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Apr 19, 2022
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you @gvillafanetapia for these changes. I made a minor suggestion.
Could you please update the changelog in docs/integrations/sources/twilio.md and bump the connector version in:

  • airbyte-integrations/connectors/source-twilio/Dockerfile
  • airbyte-config/init/src/main/resources/seed/source_definitions.yaml
  • airbyte-config/init/src/main/resources/seed/source_specs.yaml

@alafanechere
Copy link
Contributor

alafanechere commented Apr 20, 2022

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2195897834
❌ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2195897834
🐛 https://gradle.com/s/sclqzyb2gvuxe
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
=================== 4 failed, 18 passed in 115.16s (0:01:55) ===================

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2195897834
❌ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2195897834
🐛 https://gradle.com/s/6cisqedmeexwq
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
=================== 2 failed, 20 passed in 165.23s (0:02:45) ===================

…reams.py

Co-authored-by: Augustin <augustin@airbyte.io>
@gvillafanetapia gvillafanetapia marked this pull request as draft April 20, 2022 15:02
@alafanechere
Copy link
Contributor

@gvillafanetapia The tests are not passing because of some updates that needed to be made on this connector. I did the updates here #12183 and will re-run the tests here once it's merged.

@alafanechere alafanechere marked this pull request as ready for review April 21, 2022 08:06
@alafanechere
Copy link
Contributor

alafanechere commented Apr 21, 2022

Hey @gvillafanetapia, I merged #12183 . Do you mind:

  • Merging master on your branch
  • Re bumping the version to 0.1.4 ?
    I'll run the tests afterward.

@alafanechere
Copy link
Contributor

alafanechere commented Apr 22, 2022

/publish connector=connectors/source-twilio auto-bump-version=false

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2206128806
🚀 Successfully published connectors/source-twilio
✅ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2206128806

@alafanechere
Copy link
Contributor

Thank you @gvillafanetapia for the improvement! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants