Source Google Ads: change *_labels stream type from int to string in schema #12158

jagannathsrs · 2022-04-19T22:44:47Z

What

Describe what the change is solving

Solves #12096 and #11884

How

The types for ad_group_ad.ad.resource_name, label.name, label.resource_name, ad_group.resource_name have been misinterpreted as integers. According to the docs, they are of type RESOURCE_NAME which is The unique identifier for an entity in the Google Ads API is called a resource name, and is represented as a string with a predictable format.....

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2022-04-19T22:44:55Z

All committers have signed the CLA.

alafanechere

@jagannathsrs thank you for this cleaning!!!

alafanechere · 2022-04-22T18:23:32Z

/publish connector=connectors/source-google-ads auto-bump-version=false

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2209382224
❌ Failed to publish connectors/source-google-ads
🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2209382224
❌ Failed to publish connectors/source-google-ads

alafanechere · 2022-04-22T18:49:45Z

@jagannathsrs the test TestFullRefresh.test_sequential_reads is failing. Do you manage to make it pass locally?
I'm wondering if this is transient, I restarted it.

jagannathsrs · 2022-04-25T16:44:19Z

@jagannathsrs the test TestFullRefresh.test_sequential_reads is failing. Do you manage to make it pass locally? I'm wondering if this is transient, I restarted it.

I am having trouble running the tests locally, could you tell me how to run them?

alafanechere · 2022-04-26T10:36:43Z

You can run ./gradlew :airbyte-integrations:connectors:source-google-ads:integrationTest from the root of the repo. But you need a config.json set in airbyte-integrations/connectors/source-google-ads/secrets/config.json

alafanechere · 2022-04-26T22:11:05Z

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2229647646
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2229647646
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/google_ads.py               68     10    85%
source_google_ads/streams.py                 136     26    81%
source_google_ads/source.py                   80     27    66%
source_google_ads/custom_query_stream.py      75     50    33%
--------------------------------------------------------------
TOTAL                                        361    113    69%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/source.py                   80      4    95%
source_google_ads/streams.py                 136     10    93%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/google_ads.py               68      7    90%
--------------------------------------------------------------
TOTAL                                        361     27    93%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 21 passed, 1 skipped in 270.33s (0:04:30) ===================

alafanechere

LGTM! Let's try to publish again.

alafanechere · 2022-04-27T11:17:06Z

/publish connector=connectors/source-google-ads auto-bump-version=false

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2232700313
🚀 Successfully published connectors/source-google-ads
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2232700313

alafanechere · 2022-04-28T15:14:45Z

Thank you @jagannathsrs for the contribution!

…schema (#12158)

Change type to string

d42294c

github-actions bot added the area/connectors Connector related issues label Apr 19, 2022

octavia-squidington-iii added the community label Apr 19, 2022

Bump docker version, add changelog

5a4b878

github-actions bot added the area/documentation Improvements or additions to documentation label Apr 19, 2022

alafanechere self-assigned this Apr 22, 2022

alafanechere added 2 commits April 22, 2022 20:19

regenerate source_specs

1ae4098

Merge branch 'master' into fix-12096

0ee38f8

alafanechere approved these changes Apr 22, 2022

View reviewed changes

Merge branch 'master' into fix-12096

7438945

alafanechere approved these changes Apr 27, 2022

View reviewed changes

alafanechere merged commit 31485d7 into airbytehq:master Apr 28, 2022

This was referenced Apr 28, 2022

Bump Airbyte version from 0.36.4-alpha to 0.36.5-alpha #12448

Merged

Bump Airbyte version from 0.36.4-alpha to 0.36.5-alpha #12453

Closed

suhomud pushed a commit that referenced this pull request May 23, 2022

Source Google Ads: change *_labels stream type from int to string in …

3078bba

…schema (#12158)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Google Ads: change *_labels stream type from int to string in schema #12158

Source Google Ads: change *_labels stream type from int to string in schema #12158

jagannathsrs commented Apr 19, 2022

CLAassistant commented Apr 19, 2022 •

edited

Loading

alafanechere left a comment

alafanechere commented Apr 22, 2022 •

edited by github-actions bot

Loading

alafanechere commented Apr 22, 2022 •

edited

Loading

jagannathsrs commented Apr 25, 2022

alafanechere commented Apr 26, 2022

alafanechere commented Apr 26, 2022 •

edited by github-actions bot

Loading

alafanechere left a comment

alafanechere commented Apr 27, 2022 •

edited by github-actions bot

Loading

alafanechere commented Apr 28, 2022

Source Google Ads: change *_labels stream type from int to string in schema #12158

Source Google Ads: change *_labels stream type from int to string in schema #12158

Conversation

jagannathsrs commented Apr 19, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Apr 19, 2022 • edited Loading

alafanechere left a comment

Choose a reason for hiding this comment

alafanechere commented Apr 22, 2022 • edited by github-actions bot Loading

alafanechere commented Apr 22, 2022 • edited Loading

jagannathsrs commented Apr 25, 2022

alafanechere commented Apr 26, 2022

alafanechere commented Apr 26, 2022 • edited by github-actions bot Loading

alafanechere left a comment

Choose a reason for hiding this comment

alafanechere commented Apr 27, 2022 • edited by github-actions bot Loading

alafanechere commented Apr 28, 2022

CLAassistant commented Apr 19, 2022 •

edited

Loading

alafanechere commented Apr 22, 2022 •

edited by github-actions bot

Loading

alafanechere commented Apr 22, 2022 •

edited

Loading

alafanechere commented Apr 26, 2022 •

edited by github-actions bot

Loading

alafanechere commented Apr 27, 2022 •

edited by github-actions bot

Loading