SAT: support yaml files in spec_path #12228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroslopez
commented
Apr 20, 2022
Comment on lines
119
to
+121
| def connector_spec_fixture(connector_spec_path) -> ConnectorSpecification: | ||
| return ConnectorSpecification.parse_file(connector_spec_path) | ||
| spec_obj = load_yaml_or_json_path(connector_spec_path) | ||
| return ConnectorSpecification.parse_obj(spec_obj) |
There was a problem hiding this comment.
looks like we can't test these fixtures directly, so moved the yaml/json logic into a utility method
|
/publish connector=bases/source-acceptance-test
|
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* support yaml files as spec_path * no unnecessary f-string * move to util for better testing * bump version, update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We now support loading the spec from a yaml file in the CDK (#12104), but the SAT still expects a json file as
spec_pathfor one of the tests.How
Check if
spec_pathis a.jsonor.yamlfile and load accordingly.