🎉 Source Freshdesk: Migrated to latest CDK #12334

lgomezm · 2022-04-26T03:34:26Z

What

The Freshdesk source connector was written way before the current CDK version and is using outdated patterns.
It should be re-written using the latest CDK patterns,

How

Migrated the source connector to latest CDK.
Code is significantly simplified after these changes.
Added a few tests to cover new code.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

lgomezm · 2022-04-26T03:38:29Z

Here's the acceptance test results:

lgomezm · 2022-04-26T03:39:42Z

Here's the unit test results:

marcosmarxm · 2022-04-26T16:51:59Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2228133298
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2228133298
🐛 https://gradle.com/s/q5lb43jc4ja3a

itaseskii · 2022-04-26T18:43:13Z

I'll start code reviewing this.

alafanechere · 2022-04-27T17:29:45Z

Thanks @itaseskii , feel free to ping me if you need an additional review.

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/source.py

itaseskii · 2022-05-03T17:31:45Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/source.py

+    def streams(self, config: Mapping[str, Any]) -> List[Stream]:
+        authenticator = self._create_authenticator(config["api_key"])
+        return [
+            Agents(authenticator=authenticator, config=config),


Aren't you missing the Surveys stream from the original implementation?

Good catch! I should have missed it when migrating individual streams. Added back in 4e2f437.

itaseskii · 2022-05-03T17:33:34Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/source.py

+        alive = True
+        error_msg = None
+        try:
+            url = f"https://{config['domain'].rstrip('/')}/api/v2/settings/helpdesk"


Using urljoin for url concatenation is a bit more readable

Nice. I didn't know about that function. Changed in 4e2f437.

itaseskii · 2022-05-03T18:12:29Z

airbyte-integrations/connectors/source-freshdesk/unit_tests/test_source.py

+    requests_mock.register_uri("GET", "/api/v2/settings/helpdesk", responses)
+    ok, error_msg = SourceFreshdesk().check_connection(logger, config=config)
+
+    assert not ok


use single line statements/assertions assert not ok and error_msg == ""

Updated in 4e2f437.

itaseskii · 2022-05-03T18:30:28Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

+        self, stream_state: Mapping[str, Any], stream_slice: Mapping[str, Any] = None, next_page_token: Mapping[str, Any] = None
+    ) -> Mapping[str, Any]:
+        return {
+            "Content-Type": "application/json",


Why is "Content-Type": "application/json" needed when sending a request? Aren't all the requests of GET type and without a body?

You're right. Turns out it works without having to send these headers. I simplified the code by removing this method in 4e2f437.

itaseskii · 2022-05-03T18:51:00Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

+        return "time_entries"
+
+
+class Tickets(IncrementalFreshdeskStream):


Given that Tickets will be retrieved in ascending order maybe we can set a state_checkpoint_interval = 100 in order to persist state on every 100 records and avoid sending previously sent records if the replication crashes midway?

https://github.com/airbytehq/airbyte/blob/master/docs/connector-development/cdk-python/incremental-stream.md#interval-based-checkpointing

Awesome. I added this in 4e2f437. Thank you for the suggestion!

I suggest you set state_checkpoint_interval on all the Incremental streams, or you can implement stream_slices. If you implement stream slicing the state will be checkpointed once a slice was properly consumed.

Added in abcae41.

itaseskii · 2022-05-03T18:55:18Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

+        pagination_complete = False
+
+        next_page_token = None
+        with AirbyteSentry.start_transaction("read_records", self.name), AirbyteSentry.start_transaction_span("read_records"):


Would you mind explaining why copying large amounts of the parent streamread_records()is needed instead of invoking super().read_records()

You made me re-think how I migrated this particular stream and I ended up overriding the next_page_token method instead of the read_records one. In the end, I had to intervene the next_page_token if the next page to get was above 300. The method now has a comment that was ported from the original implementation. See b0bcf0e.

itaseskii · 2022-05-03T19:05:24Z

Will do another round of code reviewing tomorrow.

alafanechere · 2022-05-04T07:30:57Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

+            yield element
+
+
+class IncrementalFreshdeskStream(FreshdeskStream, ABC):


Suggested change

class IncrementalFreshdeskStream(FreshdeskStream, ABC):

class IncrementalFreshdeskStream(FreshdeskStream, IncrementalMixin):

The latest CDK introduces the IncrementalMixin class. I suggest you use it and set the state value in read_records as suggested here. get_updated_state is now deprecated.

Added in abcae41

alafanechere · 2022-05-04T07:33:47Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

+        return "time_entries"
+
+
+class Tickets(IncrementalFreshdeskStream):


I suggest you set state_checkpoint_interval on all the Incremental streams, or you can implement stream_slices. If you implement stream slicing the state will be checkpointed once a slice was properly consumed.

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/source.py

alafanechere · 2022-05-04T07:37:15Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/source.py

+        alive = True
+        error_msg = None
+        try:
+            url = f"https://{config['domain'].rstrip('/')}/api/v2/settings/helpdesk"


nit: a more robust way of checking connection would be to request several actual streams endpoints

alafanechere · 2022-05-04T07:38:00Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/source.py

+        try:
+            url = f"https://{config['domain'].rstrip('/')}/api/v2/settings/helpdesk"
+            r = requests.get(url=url, auth=self._create_authenticator(config["api_key"]))
+            if not r.ok:


I would suggest leveraging r.raise_for_status() and handling the error if it's raised.

Sure. Updated in 24d1581.

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/source.py

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

lgomezm · 2022-05-05T05:11:48Z

Hi @alafanechere. Thank you for reviewing. I've updated this PR as per your comments. Please take a look again when you get a chance.

CLAassistant · 2022-05-05T13:09:41Z

All committers have signed the CLA.

alafanechere

I went for another partial review but need to switch context. I'll review the rest asap.

alafanechere · 2022-05-05T13:33:06Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/source.py

+            except ValueError:
+                error_msg = "Invalid credentials"


In which situation ValueError is raised here?
If whatever non HTTPError is raised is I don't think the cause would be Invalid Credential.
I think this try except block is redundant as non HttpError are watched by the higher level except Exception as error:

You're right. I've removed the handling of this kind of error.

alafanechere · 2022-05-05T13:36:14Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/source.py

+        return alive, error_msg
+
+    def streams(self, config: Mapping[str, Any]) -> List[Stream]:
+        authenticator = self._create_authenticator(config["api_key"])


Suggested change

authenticator = self._create_authenticator(config["api_key"])

authenticator = HTTPBasicAuthNoPassword(config["api_key"])

Renamed authenticator class with FreshdeskAuth and used here.

alafanechere · 2022-05-05T13:36:57Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/source.py


+class HTTPBasicAuthNoPassword(HTTPBasicAuth):


nit:

Suggested change

class HTTPBasicAuthNoPassword(HTTPBasicAuth):

class FreshdeskAuth(HTTPBasicAuth):

alafanechere · 2022-05-05T13:42:18Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

+        # Since this logic rely not on updated tickets, it can break tickets dependant streams - conversations.
+        # So updated_since parameter will be always used in tickets streams. And start_date will be used too
+        # with default value 30 days look back.
+        self.start_date = pendulum.parse(start_date) if start_date else pendulum.now() - pendulum.duration(days=30)


Suggested change

self.start_date = pendulum.parse(start_date) if start_date else pendulum.now() - pendulum.duration(days=30)

self.start_date = pendulum.parse(config["start_date"]) if config["start_date"] else pendulum.now() - pendulum.duration(days=30)

alafanechere · 2022-05-05T13:43:33Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

+
+class FreshdeskStream(HttpStream, ABC):
+    """Basic stream API that allows to iterate over entities"""
+    call_credit = 1  # see https://developers.freshdesk.com/api/#embedding


This value never changes, I'd prefer to decrement from 1 rather than decrementing from this variable if it never changes.

I double checked and it was actually being used with a different value in the Tickets stream. I've updated it accordingly.

alafanechere · 2022-05-05T13:48:07Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

+
+    def backoff_time(self, response: requests.Response) -> Optional[float]:
+        if response.status_code == requests.codes.too_many_requests:
+            return float(response.headers.get("Retry-After"))


Suggested change

return float(response.headers.get("Retry-After"))

return float(response.headers.get("Retry-After", 0))

You will have a TypeError if Retry-After is not in the headers: float(None) -> TypeError

Good catch! Done.

alafanechere · 2022-05-05T13:50:57Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

+            params = parse.parse_qs(parse.urlparse(next_url).query)
+            return self.parse_link_params(link_query_params=params)
+        except Exception as e:
+            raise KeyError(f"error parsing next_page token: {e}")


Why did you choose to raise a KeyError here?
Could you please explain what kind of error you expect in this function?

Yeah, I updated this method and removed the exception handling.

alafanechere · 2022-05-05T13:52:11Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

+            match = self.link_regex.search(link_header)
+            next_url = match.group(1)
+            params = parse.parse_qs(parse.urlparse(next_url).query)
+            return self.parse_link_params(link_query_params=params)


Suggested change

return self.parse_link_params(link_query_params=params)

return {"per_page": params['per_page'][0], "page": params['page'][0]}

alafanechere · 2022-05-05T13:52:43Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

+    def parse_link_params(self, link_query_params: Mapping[str, List[str]]) -> Mapping[str, Any]:
+        return {"per_page": link_query_params['per_page'][0], "page": link_query_params['page'][0]}


Suggested change

def parse_link_params(self, link_query_params: Mapping[str, List[str]]) -> Mapping[str, Any]:

return {"per_page": link_query_params['per_page'][0], "page": link_query_params['page'][0]}

alafanechere · 2022-05-05T13:53:52Z

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

+        self, stream_state: Mapping[str, Any], stream_slice: Mapping[str, any] = None, next_page_token: Mapping[str, Any] = None
+    ) -> MutableMapping[str, Any]:
+        params = {"per_page": self.result_return_limit}
+        if next_page_token and "page" in next_page_token:


How could page not be in next_page_token if next_page_token is not None?

alafanechere

I'm done reviewing source.py and streams.py :) I made a lot of suggestions to simplify and increase readability + match CDK best practices.

airbyte-integrations/connectors/source-freshdesk/source_freshdesk/streams.py

lgomezm · 2022-05-18T02:42:55Z

@alafanechere I've addressed your comments. Please take a look again when you get a chance and let me know if there's anything else you consider I should update. Thanks!

alafanechere · 2022-05-18T14:04:30Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2346034912
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2346034912
🐛 https://gradle.com/s/uwca5iuwfwemi

alafanechere · 2022-05-18T14:05:10Z

Thank you for the changes @lgomezm , I'm running the test now and will go for a final review asap.

alafanechere · 2022-05-18T15:05:15Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2346404839
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2346404839
🐛 https://gradle.com/s/x6peupa7oyhoi
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 1 failed, 13 passed, 9 errors in 21.75s ====================

alafanechere

@lgomezm the acceptance tests are not passing. Could you please provide the required fixes? Feel free to ask if you need help understanding why the tests are not passing.

lgomezm · 2022-05-20T03:41:48Z

Hi @alafanechere. I've pushed a change that fixes acceptance tests. Please give it a try again when you get a chance. Here's the results of them running locally:

alafanechere · 2022-05-20T20:23:42Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2360495709
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2360495709
🐛 https://gradle.com/s/kd4252r2tpsm2
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
=================== 4 failed, 20 passed in 177.99s (0:02:57) ===================

alafanechere · 2022-05-23T08:18:51Z

We are facing an error while running the acceptance test with our Freshdesk account:

The Skill Based Round Robin feature(s) is/are not supported in your plan. Please upgrade your account to use it.", "internal_message": "403 Client Error: Forbidden for url: https://newaccount1603334233301.freshdesk.com/api/skills?per_page=100

I'm trying to remove the Skills stream from the tests.

alafanechere · 2022-05-23T08:18:59Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2369927218
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2369927218
🐛 https://gradle.com/s/lfnrq3374ggh2
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Timeout >300.0s
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
=================== 4 failed, 20 passed in 989.46s (0:16:29) ===================

alafanechere · 2022-05-24T09:40:02Z

@lgomezm I'll be off until next Monday. Could you please try to figure out what could be problematic with the Skills stream and try to ignore it from the integration tests if needed (it looks like my latest attempt in 77ea41b did not work)?

lgomezm · 2022-05-27T03:03:12Z

Hi @alafanechere. It looks like the test account that's used to run integration tests is not allowed to get skills. I have overwritten the configured catalog file so that the skills stream is not included in the acceptance tests. They should pass now.

alafanechere · 2022-05-30T06:58:57Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2407311353
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2407311353
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_freshdesk/source.py        31      0   100%
source_freshdesk/__init__.py       2      0   100%
source_freshdesk/streams.py      139      4    97%
source_freshdesk/utils.py         20      1    95%
--------------------------------------------------
TOTAL                            192      5    97%

Build Passed

Test summary info:

All Passed

alafanechere · 2022-05-30T08:35:57Z

Hey @lgomezm while I was off our team upgraded our freshdesk account to overcome the problem on the skills account (#13158)

alafanechere · 2022-05-30T09:15:47Z

/publish connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2408021884
🚀 Successfully published connectors/source-freshdesk
🚀 Auto-bumped version for connectors/source-freshdesk
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/2408021884

alafanechere

Thank you for the contribution @lgomezm !

github-actions bot added the area/connectors Connector related issues label Apr 26, 2022

octavia-squidington-iii added the community label Apr 26, 2022

lgomezm mentioned this pull request Apr 26, 2022

Source Freshdesk: migrate to use CDK #11456

Closed

alafanechere assigned alafanechere and itaseskii Apr 27, 2022

lgomezm force-pushed the lgomez/freshdesk_migration branch from fda8157 to 1f0cdbf Compare April 29, 2022 14:15

lgomezm mentioned this pull request May 1, 2022

🎉 Source Freshdesk: Added new streams lgomezm/airbyte#1

Closed

38 tasks

itaseskii suggested changes May 3, 2022

View reviewed changes

alafanechere reviewed May 4, 2022

View reviewed changes

alafanechere requested changes May 5, 2022

View reviewed changes

alafanechere requested changes May 6, 2022

View reviewed changes

lgomezm force-pushed the lgomez/freshdesk_migration branch from 24d1581 to 5751b4a Compare May 18, 2022 02:31

alafanechere requested changes May 18, 2022

View reviewed changes

lgomezm and others added 12 commits May 26, 2022 21:41

Added source tests

31fddeb

Added stream tests

6a599f0

Addressed PR feedback

44f786a

Add explanatory comment

7f5c7e0

Addressed more PR feedback

8ac1a2f

Leveraged response.raise_for_status

a82b8a3

Addressed PR feedback

12afc4a

format

a0a3d94

Made requests_per_minute config param optional

b7e15a7

remove skills stream from tests

962ddf6

Fixed integration tests

a64b8cf

Fixed last rebase

9cf2ba1

lgomezm force-pushed the lgomez/freshdesk_migration branch from 77ea41b to 9cf2ba1 Compare May 27, 2022 02:59

alafanechere mentioned this pull request May 30, 2022

Source Freshdesk publish new version to Docker hub #13158

Closed

38 tasks

readd skills + remove legacy changelog

3eca841

github-actions bot added the area/documentation Improvements or additions to documentation label May 30, 2022

Merge branch 'master' into lgomez/freshdesk_migration

8634096

octavia-squidington-iii and others added 2 commits May 30, 2022 09:38

auto-bump connector version

e6094f4

add endline

122c467

alafanechere approved these changes May 30, 2022

View reviewed changes

alafanechere merged commit 9d1cd42 into airbytehq:master May 30, 2022

octavia-squidington-iii mentioned this pull request May 31, 2022

Bump Airbyte version from 0.39.5-alpha to 0.39.6-alpha #13350

Merged

jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022

🎉 Source Freshdesk: Migrated to latest CDK (airbytehq#12334)

6dc215b

		return "time_entries"


		class Tickets(IncrementalFreshdeskStream):

		yield element


		class IncrementalFreshdeskStream(FreshdeskStream, ABC):

	authenticator = self._create_authenticator(config["api_key"])
	authenticator = HTTPBasicAuthNoPassword(config["api_key"])

	class HTTPBasicAuthNoPassword(HTTPBasicAuth):
	class FreshdeskAuth(HTTPBasicAuth):

	self.start_date = pendulum.parse(start_date) if start_date else pendulum.now() - pendulum.duration(days=30)
	self.start_date = pendulum.parse(config["start_date"]) if config["start_date"] else pendulum.now() - pendulum.duration(days=30)

	return float(response.headers.get("Retry-After"))
	return float(response.headers.get("Retry-After", 0))

	return self.parse_link_params(link_query_params=params)
	return {"per_page": params['per_page'][0], "page": params['page'][0]}

		def parse_link_params(self, link_query_params: Mapping[str, List[str]]) -> Mapping[str, Any]:
		return {"per_page": link_query_params['per_page'][0], "page": link_query_params['page'][0]}

🎉 Source Freshdesk: Migrated to latest CDK #12334

🎉 Source Freshdesk: Migrated to latest CDK #12334

Conversation

lgomezm commented Apr 26, 2022 • edited by aharelick Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

lgomezm commented Apr 26, 2022

lgomezm commented Apr 26, 2022

marcosmarxm commented Apr 26, 2022 • edited by github-actions bot Loading

itaseskii commented Apr 26, 2022

alafanechere commented Apr 27, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

itaseskii commented May 3, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgomezm commented May 5, 2022

CLAassistant commented May 5, 2022 • edited Loading

alafanechere left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alafanechere left a comment

Choose a reason for hiding this comment

lgomezm commented May 18, 2022

alafanechere commented May 18, 2022 • edited by github-actions bot Loading

alafanechere commented May 18, 2022

alafanechere commented May 18, 2022 • edited by github-actions bot Loading

alafanechere left a comment

Choose a reason for hiding this comment

lgomezm commented May 20, 2022

alafanechere commented May 20, 2022 • edited by github-actions bot Loading

alafanechere commented May 23, 2022

alafanechere commented May 23, 2022 • edited by github-actions bot Loading

alafanechere commented May 24, 2022

lgomezm commented May 27, 2022

alafanechere commented May 30, 2022 • edited by github-actions bot Loading

Build Passed

alafanechere commented May 30, 2022

alafanechere commented May 30, 2022 • edited by github-actions bot Loading

lgomezm commented Apr 26, 2022 •

edited by aharelick

Loading

marcosmarxm commented Apr 26, 2022 •

edited by github-actions bot

Loading

CLAassistant commented May 5, 2022 •

edited

Loading

alafanechere commented May 18, 2022 •

edited by github-actions bot

Loading

alafanechere commented May 18, 2022 •

edited by github-actions bot

Loading

alafanechere commented May 20, 2022 •

edited by github-actions bot

Loading

alafanechere commented May 23, 2022 •

edited by github-actions bot

Loading

alafanechere commented May 30, 2022 •

edited by github-actions bot

Loading

alafanechere commented May 30, 2022 •

edited by github-actions bot

Loading