-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Facebook Marketing: Add lookback window to insights streams #12402
Merged
alafanechere
merged 26 commits into
airbytehq:master
from
vladimir-remar:source-facebook-marketing-add-insights-lookback-window
May 31, 2022
Merged
Changes from 2 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d277560
WIP: add lookback window to insgiths streams
vladimir-remar 03d5a72
update: docs in
vladimir-remar 84efdab
update: add insights_lookback_window in custom insights
vladimir-remar c6d00d7
solve conflicts
vladimir-remar 50a3a9d
Merge branch 'master' into source-facebook-marketing-add-insights-loo…
vladimir-remar d30b66d
update connector version in dockerfile and update facebook-marketing.md
vladimir-remar e12deff
fix conflicts
vladimir-remar 71f326a
formatting using blackFormat
vladimir-remar b1481da
add minimun value to insights_lookback_window field and replace exclu…
vladimir-remar 14b3007
fix unit tests: test_base_insight_streams
vladimir-remar 439d527
fix order on specs
vladimir-remar a0d13f8
update integration spec file
vladimir-remar 384682b
Merge branch 'master' into source-facebook-marketing-add-insights-loo…
alafanechere d549143
update test spec.json
alafanechere c86417f
update test spec.json
alafanechere 3f67e25
fix conflicts
vladimir-remar fb66ecb
Merge branch 'master' into source-facebook-marketing-add-insights-loo…
vladimir-remar 246c2dd
update refresh date
vladimir-remar b39262a
update test_base_insight_streams
vladimir-remar a6577ed
remove round brackets from insights_lookback_window description
vladimir-remar 4524fc4
remove monkeypatch for AdsInsights in test_incremental_lookback_perio…
vladimir-remar fb99be7
Merge branch 'master' into source-facebook-marketing-add-insights-loo…
vladimir-remar fe1b30a
update connector version in Dockerfile
vladimir-remar b7d7973
fix typo in changelog
alafanechere 944783d
Merge branch 'master' into source-facebook-marketing-add-insights-loo…
alafanechere 7483176
auto-bump connector version
octavia-squidington-iii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should make this
default_insights_lookback_window
and apply it only to the default insights synced by this connector, and separately we should allow configuring this on a per-insight level in the custom insightsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your patience I will work on this ASAP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vladimir-remar I'm not sure you ended up implementing @sherifnada suggestion. Is anything blocking you from going in the suggested direction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @alafanechere, maybe I'm wrong, I just replicate the same approach in the custom insight part.
airbyte/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/spec.py
Line 80 in c6d00d7