Choose optimal sync modes by default on UI #12411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync Mode priority: 1. Incremental(cursor defined) => Append Dedup 2. Full Refresh => Overwrite 3. Incremental => Append 4. Full Refresh => Append
|
|
edmundito
reviewed
Apr 27, 2022
airbyte-webapp/src/views/Connection/ConnectionForm/formConfigHelpers.ts
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/views/Connection/ConnectionForm/formConfigHelpers.ts
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/views/Connection/ConnectionForm/formConfig.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/views/Connection/ConnectionForm/formConfig.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/views/Connection/ConnectionForm/formConfigHelpers.ts
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/views/Connection/ConnectionForm/formConfigHelpers.ts
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/views/Connection/ConnectionForm/formConfigHelpers.ts
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/views/Connection/ConnectionForm/formConfigHelpers.ts
Outdated
Show resolved
Hide resolved
- replace func "isEmpty" with "[].length" - replace named export with direct export - update "config" type for updateStreamConfig func - rename "getOptimalSyncMode" to "setOptimalSyncMode"
edmundito
approved these changes
Apr 29, 2022
krishnaglick
approved these changes
Apr 29, 2022
krishnaglick
deleted the
9625-choose-optimal-sync-modes-by-default-on-ui
branch
teallarson
added a commit
that referenced
this pull request
May 4, 2022
This reverts commit 6897a60.
teallarson
added a commit
that referenced
this pull request
May 4, 2022
dizel852
added a commit
that referenced
this pull request
May 11, 2022
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* fix CatalogSectionInner component padding * fix React key error in StreamFieldTable component * Update choosing the optimal sync mode logic. Sync Mode priority: 1. Incremental(cursor defined) => Append Dedup 2. Full Refresh => Overwrite 3. Incremental => Append 4. Full Refresh => Append * Fixes after comments to PR: - replace func "isEmpty" with "[].length" - replace named export with direct export - update "config" type for updateStreamConfig func - rename "getOptimalSyncMode" to "setOptimalSyncMode" * remove fp-ts package * fix wrong condition * cover formConfigHelpers with tests * add npm script: run tests with coverage * tiny fix: test assert
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
dizel852
added a commit
that referenced
this pull request
May 31, 2022
* Revert "Revert "Choose optimal sync modes by default on UI (#12411)" (#12583)" This reverts commit 9789ffd. * get optimal sync mode only in creation mode * sort sync mode options by priority * add tests for calculateInitialCatalog * remove duplicated tests * fixed one-line 'if' * move calculationInitialCatalog function to file and export it as default * - fix merge conflicts - fix Type * update tests
jscottpolevault
pushed a commit
to jscottpolevault/airbyte
that referenced
this pull request
Jun 1, 2022
…ehq#12770) * Revert "Revert "Choose optimal sync modes by default on UI (airbytehq#12411)" (airbytehq#12583)" This reverts commit 9789ffd. * get optimal sync mode only in creation mode * sort sync mode options by priority * add tests for calculateInitialCatalog * remove duplicated tests * fixed one-line 'if' * move calculationInitialCatalog function to file and export it as default * - fix merge conflicts - fix Type * update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #9625
Set the optimal sync modes for Source and Destination by default on UI.
How
Choosing the mode by priority:
Tests