generate AirbyeTraceMessage.type enum with descriptive class name
#12581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
sherifnada
approved these changes
May 4, 2022
airbyte-protocol/models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
…title' into pedroslopez/protocol-trace-enum-title
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
…12581) * generate AirbyeTraceMessage `type` enum with descriptive class name * add comment on `title` usage Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * apply changes to bases/airbyte-protocol Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The autogenerated enum for
AirbyteTraceMessage'stypeproperty was namedType1because of a conflict with the existingAirbyteMessagetype enum (namedType). This class name is not very descriptive.How
Set a
titleon the protocol definition and pass the--use-title-as-class-nameflag to generate a better name for the enum class (TraceType