Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Ads: Improve unit and integration tests #12651

Merged
merged 5 commits into from
May 9, 2022
Merged

Source Google Ads: Improve unit and integration tests #12651

merged 5 commits into from
May 9, 2022

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented May 6, 2022 •
edited
Loading

  • Mock unit tests
  • Reimplement two custom integration tests that replace commented out SATs
  • Speed up Dockerfile

Note: some of the SATs are disabled due to current constraints, so custom integration tests are implemented instead. The issue describes the problem and the solution. After it is implemented, SATs can be enabled

@davydov-d davydov-d self-assigned this May 6, 2022
@davydov-d davydov-d linked an issue May 6, 2022 that may be closed by this pull request
Source Google Ads: improve unit and integration tests #12650
Closed
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 6, 2022
@davydov-d davydov-d requested a review from bazarnov May 6, 2022 09:19
@davydov-d
Copy link
Collaborator Author

davydov-d commented May 6, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2280846506
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2280846506
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/google_ads.py               68     10    85%
source_google_ads/streams.py                 138     22    84%
source_google_ads/source.py                   80     27    66%
source_google_ads/custom_query_stream.py      75     50    33%
--------------------------------------------------------------
TOTAL                                        363    109    70%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/source.py                   80      3    96%
source_google_ads/streams.py                 138     11    92%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/google_ads.py               68     14    79%
--------------------------------------------------------------
TOTAL                                        363     34    91%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 21 passed, 1 skipped in 298.46s (0:04:58) ===================

@davydov-d davydov-d requested a review from midavadim May 6, 2022 09:54
midavadim
midavadim approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@midavadim midavadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update can be merged without Airbyte review

airbyte-integrations/connectors/source-google-ads/integration_tests/test_incremental.py Show resolved Hide resolved
@davydov-d
Copy link
Collaborator Author

davydov-d commented May 9, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2294944889
🚀 Successfully published connectors/source-google-ads
🚀 Auto-bumped version for connectors/source-google-ads
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2294944889

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 9, 2022 15:08 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 9, 2022 15:08 Inactive
@davydov-d davydov-d merged commit d4f8b25 into master May 9, 2022
@davydov-d davydov-d deleted the ddavydov/12650-source-google-ads-tests branch May 9, 2022 15:34
suhomud pushed a commit that referenced this pull request May 23, 2022
@davydov-d @octavia-squidington-iii @suhomud
Source Google Ads: Improve unit and integration tests (#12651)
5e4b8e9 
* #12650 source Googel ads: tests

* #12650 source google ads: add changelog item

* #12650 source google ads: add comments to tests

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midavadim midavadim midavadim approved these changes

@bazarnov bazarnov bazarnov approved these changes

Assignees

@davydov-d davydov-d

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Google Ads: improve unit and integration tests
4 participants
@davydov-d @midavadim @bazarnov @octavia-squidington-iii