Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySql destination : Enable DAT tests #12866

Merged
merged 6 commits into from
May 19, 2022
Merged

MySql destination : Enable DAT tests #12866

merged 6 commits into from
May 19, 2022

Conversation

DoNotPanicUA
Copy link
Contributor

@DoNotPanicUA DoNotPanicUA commented May 16, 2022 •
edited

What

The MySql destination fails the DAT tests. It means that we can't guarantee full data type compliance.

How

Enable DAT tests and fix all errors.

Recommended reading order

  1. MySqlTestDataComparator.java
  2. MySQLDestinationAcceptanceTest.java

@DoNotPanicUA

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the area/connectors Connector related issues label May 16, 2022
@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented May 19, 2022 •
edited by github-actions bot

/test connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/2351893178
✅ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/2351893178
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_config/transform.py                         159     31    81%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 543    352    35%
-------------------------------------------------------------------------------------
TOTAL                                                              1333    559    58%

@DoNotPanicUA DoNotPanicUA self-assigned this May 19, 2022
@DoNotPanicUA DoNotPanicUA marked this pull request as ready for review May 19, 2022 12:55
@DoNotPanicUA DoNotPanicUA merged commit 5aa7fe7 into master May 19, 2022
@DoNotPanicUA DoNotPanicUA deleted the aleonets/DAT-mysql branch May 19, 2022 12:55
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 20, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@DoNotPanicUA @suhomud
MySql destination : Enable DAT tests (#12866)
be20709 
* add MySqlTestDataComparator

* enable new DAT

* enable new DAT

* handle json type + fix boolean compare for both cases

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashaNeshcheret sashaNeshcheret sashaNeshcheret approved these changes

@alexandr-shegeda alexandr-shegeda Awaiting requested review from alexandr-shegeda

Assignees

@DoNotPanicUA DoNotPanicUA

Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DoNotPanicUA @sashaNeshcheret