Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update Qualaroo Spec #13042

Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-qualaroo/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ COPY source_qualaroo ./source_qualaroo
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.name=airbyte/source-qualaroo
Original file line number Diff line number Diff line change
Expand Up @@ -2,66 +2,66 @@
"type": "object",
"properties": {
"id": {
"type": "integer"
"type": ["null", "integer"]
},
"time": {
"type": "string",
"type": ["null", "string"],
"format": "date-time"
},
"identity": {
"type": ["null", "string"]
},
"page": {
"type": "string"
"type": ["null", "string"]
},
"referrer": {
"type": ["null", "string"]
},
"user_agent": {
"type": "string"
"type": ["null", "string"]
},
"nudge_id": {
"type": "integer"
"type": ["null", "integer"]
},
"nudge_name": {
"type": "string"
"type": ["null", "string"]
},
"anon_visitor_id": {
"type": "string"
"type": ["null", "string"]
},
"ip_address": {
"type": "string"
"type": ["null", "string"]
},
"answered_questions": {
"type": "array",
"items": {
"type": "object"
"type":["null", "object"]
}
},
"properties": {
"type": "object"
"type":["null", "object"]
},
"nps": {
"type": "object",
"type": ["null", "object"],
Copy link
Contributor Author

@danieldiamond danieldiamond May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I remove this NPS object from the response.json and still be able to pull it from the _AIRBYTE_RAW_RESPONSES table?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it won't add to raw if you remove from schema.

"properties": {
"score": {
"type": "integer"
"type": ["null", "integer"]
},
"reason": {
"type": "string"
"type": ["null", "string"]
},
"respondent_id": {
"type": "integer"
"type": ["null", "integer"]
},
"time": {
"type": "string",
"type": ["null", "string"],
"format": "date-time"
},
"category": {
"type": "string"
"type": ["null", "string"]
},
"response_uri": {
"type": "string"
"type": ["null", "string"]
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,32 +2,32 @@
"type": "object",
"properties": {
"id": {
"type": "integer"
"type": ["null", "integer"]
},
"site_id": {
"type": "integer"
"type": ["null", "integer"]
},
"uuid": {
"type": ["null", "string"]
},
"name": {
"type": "string"
"type": ["null", "string"]
},
"active": {
"type": "boolean"
"type": ["null", "boolean"]
},
"kind": {
"type": "string"
"type": ["null", "string"]
},
"canonical_name": {
"type": ["null", "string"]
},
"created_at": {
"type": "string",
"type": ["null", "string"],
"format": "date-time"
},
"survey_url": {
"type": "string"
"type": ["null", "string"]
}
}
}
1 change: 1 addition & 0 deletions docs/integrations/sources/qualaroo.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,6 @@ Please read [How to get your APIs Token and Key](https://help.qualaroo.com/hc/en

| Version | Date | Pull Request | Subject |
| :--- | :--- | :--- | :--- |
| 0.1.1 | 2022-05-20 | [13042](https://github.com/airbytehq/airbyte/pull/13042) | Update stream specs |
| 0.1.0 | 2021-08-18 | [8623](https://github.com/airbytehq/airbyte/pull/8623) | New source: Qualaroo |