Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integration tests are failing for tiktok-marketing #13127

Merged
merged 4 commits into from
May 24, 2022

Conversation

harshithmullapudi
Copy link
Contributor

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added the area/connectors Connector related issues label May 24, 2022
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 24, 2022

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2378917044
❌ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2378917044
🐛 https://gradle.com/s/evuejvcajmk34

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
================== 1 failed, 60 passed in 1820.35s (0:30:20) ===================

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label May 24, 2022
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 24, 2022 15:43 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 24, 2022

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2379573283
❌ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2379573283
🐛 https://gradle.com/s/ayzr7r4egcklq

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
================== 1 failed, 60 passed in 1736.16s (0:28:56) ===================

@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 24, 2022

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2379799756
❌ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2379799756
🐛 https://gradle.com/s/esfk5talao4je

Build Failed

Test summary info:

Could not find result summary

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 24, 2022 18:22 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 24, 2022

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2379848791
❌ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2379848791
🐛 https://gradle.com/s/56mulawwzr3ui

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_config_match_spec[inputs0] - Failed: Conf...
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
FAILED test_core.py::TestConnection::test_check[inputs0] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs1] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs2] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs3] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs4] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs5] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs6] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs7] - docker.errors.Cont...
FAILED test_core.py::TestConnection::test_check[inputs8] - docker.errors.Cont...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - docker.errors.Co...
FAILED test_core.py::TestDiscovery::test_discover[inputs1] - docker.errors.Co...
FAILED test_core.py::TestDiscovery::test_discover[inputs2] - docker.errors.Co...
FAILED test_core.py::TestDiscovery::test_discover[inputs3] - docker.errors.Co...
FAILED test_core.py::TestDiscovery::test_discover[inputs4] - docker.errors.Co...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs2]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs3]
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs4]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs2]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs3]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs4]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs1-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs1-not]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs2-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs2-not]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs3-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs3-not]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs4-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs4-not]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs2]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs3]
ERROR test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs4]
ERROR test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contain...
ERROR test_core.py::TestBasicRead::test_read[inputs1] - docker.errors.Contain...
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
ERROR test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
ERROR test_incremental.py::TestIncremental::test_two_sequential_reads[inputs1]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
ERROR test_incremental.py::TestIncremental::test_read_sequential_slices[inputs1]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs1]
============= 16 failed, 10 passed, 35 errors in 64.45s (0:01:04) ==============

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 24, 2022 18:33 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 24, 2022

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2379938461
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2379938461
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                  Stmts   Miss  Cover
---------------------------------------------------------
source_tiktok_marketing/spec.py          59      0   100%
source_tiktok_marketing/source.py        49      0   100%
source_tiktok_marketing/__init__.py       2      0   100%
source_tiktok_marketing/streams.py      319     25    92%
---------------------------------------------------------
TOTAL                                   429     25    94%

Build Passed

Test summary info:

All Passed

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 24, 2022 18:52 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 24, 2022

/test connector=connectors/source-tiktok-marketing

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2379950157
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2379950157
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                  Stmts   Miss  Cover
---------------------------------------------------------
source_tiktok_marketing/spec.py          59      0   100%
source_tiktok_marketing/source.py        49      0   100%
source_tiktok_marketing/__init__.py       2      0   100%
source_tiktok_marketing/streams.py      319     25    92%
---------------------------------------------------------
TOTAL                                   429     25    94%

Build Passed

Test summary info:

All Passed

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 24, 2022 18:55 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented May 24, 2022

/publish connector=connectors/source-tiktok-marketing auto-bump-version=false

🕑 connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2380161190
🚀 Successfully published connectors/source-tiktok-marketing
✅ connectors/source-tiktok-marketing https://github.com/airbytehq/airbyte/actions/runs/2380161190

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets May 24, 2022 20:03 Inactive
@harshithmullapudi harshithmullapudi merged commit 073bbbc into master May 24, 2022
@harshithmullapudi harshithmullapudi deleted the harshith/tiktok-fix branch May 24, 2022 20:08
jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022
)

* fix: integration tests are failing for tiktok-marketing

* fix: integration tests are failing for tiktok-marketing

* chore: publish new version

* chore: update seed file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant