Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Intercom: fix conversation_parts stream schema #13204

Merged
merged 3 commits into from May 25, 2022

Conversation

pedroslopez
Copy link
Contributor

@pedroslopez pedroslopez commented May 25, 2022

What

An error in the schema definition for the conversation_parts stream was causing syncs to fail due to schema validations occurring after #12231

This was failing against a valid record:

{
  "type" : "conversation_part",
  "id" : "9871038696",
  "part_type" : "message_assignment",
  "body" : null,
  "created_at" : 1625749234,
  "updated_at" : 1625749234,
  "notified_at" : 1625749234,
  "assigned_to" : {
    "type" : "admin",
    "id" : "4423433"
  },
  "author" : {
    "id" : "4423434",
    "type" : "bot",
    "name" : "Operator",
    "email" : "operator+wjw5eps7@intercom.io"
  },
  "attachments" : [ ],
  "external_id" : null,
  "redacted" : false,
  "conversation_id" : "2"
}

How

Fix the schema definition

@github-actions github-actions bot added the area/connectors Connector related issues label May 25, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label May 25, 2022
@pedroslopez
Copy link
Contributor Author

pedroslopez commented May 25, 2022

/test connector=source-intercom

🕑 source-intercom https://github.com/airbytehq/airbyte/actions/runs/2387285715
✅ source-intercom https://github.com/airbytehq/airbyte/actions/runs/2387285715
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_intercom/__init__.py       2      0   100%
source_intercom/source.py       242     48    80%
-------------------------------------------------
TOTAL                           244     48    80%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_intercom/__init__.py       2      0   100%
source_intercom/source.py       242     19    92%
-------------------------------------------------
TOTAL                           244     19    92%

Build Passed

Test summary info:

	 =========================== short test summary info ============================
	 SKIPPED [9] integration_tests/integration_test.py:31: need to refresh this test, it is very slow
	 �[33m============= �[32m2 passed�[0m, �[33m�[1m9 skipped�[0m, �[33m�[1m15 warnings�[0m�[33m in 67.08s (0:01:07)�[0m�[33m =============�[0m

Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find! lgtm

@pedroslopez
Copy link
Contributor Author

pedroslopez commented May 25, 2022

/publish connector=source-intercom

❌ Failed to publish source-intercom
❌ Couldn't auto-bump version for source-intercom

@pedroslopez pedroslopez marked this pull request as ready for review May 25, 2022 21:58
@pedroslopez
Copy link
Contributor Author

pedroslopez commented May 25, 2022

/publish connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/2387370548
🚀 Successfully published connectors/source-intercom
🚀 Auto-bumped version for connectors/source-intercom
✅ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/2387370548

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 25, 2022 22:15 Inactive
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@d7cffe4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13204   +/-   ##
=========================================
  Coverage          ?   92.21%           
=========================================
  Files             ?        2           
  Lines             ?      244           
  Branches          ?        0           
=========================================
  Hits              ?      225           
  Misses            ?       19           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7cffe4...7333c5f. Read the comment docs.

@pedroslopez pedroslopez merged commit d2aedc7 into master May 25, 2022
@pedroslopez pedroslopez deleted the pedroslopez/intercom-schema-fix branch May 25, 2022 22:44
jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022
…13204)

* fix conversation_parts schema

* bump version, update changelog

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants