Bump faker version to test M1 Connector builds #13235

evantahler · 2022-05-26T18:38:59Z

No actual changes to the connector other than the version number. This is a test of #13004

evantahler · 2022-05-26T18:39:24Z

/test connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2392466828
❌ connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2392466828
🐛 https://gradle.com/s/rvrjc24lqxw2m

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: Stre...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 1 failed, 20 passed, 1 skipped in 16.38s ===================

codecov · 2022-05-26T18:46:23Z

Codecov Report

❗ No coverage uploaded for pull request base (master@65f79d2). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 6bd7833 differs from pull request most recent head 9509bcf. Consider uploading reports for the commit 9509bcf to get more accurate results

@@            Coverage Diff            @@
##             master   #13235   +/-   ##
=========================================
  Coverage          ?   96.07%           
=========================================
  Files             ?        2           
  Lines             ?       51           
  Branches          ?        0           
=========================================
  Hits              ?       49           
  Misses            ?        2           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f79d2...9509bcf. Read the comment docs.

evantahler · 2022-05-26T19:03:23Z

/test connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2392581462
✅ connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2392581462
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                       Stmts   Miss  Cover
----------------------------------------------
source_faker/__init__.py       2      0   100%
source_faker/source.py        49      2    96%
----------------------------------------------
TOTAL                         51      2    96%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 21 passed, 1 skipped in 16.47s ========================

evantahler · 2022-05-26T19:56:15Z

Soar Scan seems like a buggy test reporter... I don't think that failure should prevent this PR merge

evantahler · 2022-05-26T19:59:04Z

/publish connector=connectors/source-faker

❌ Failed to publish connectors/source-faker
❌ Couldn't auto-bump version for connectors/source-faker

sherifnada · 2022-05-26T21:23:41Z

/publish connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2393210381
❌ Failed to publish connectors/source-faker
❌ Couldn't auto-bump version for connectors/source-faker

evantahler · 2022-05-26T23:43:39Z

/publish connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2393726888
❌ Failed to publish connectors/source-faker
❌ Couldn't auto-bump version for connectors/source-faker

evantahler · 2022-05-27T00:27:00Z

/publish connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2393867916
❌ Failed to publish connectors/source-faker
❌ Couldn't auto-bump version for connectors/source-faker

evantahler · 2022-05-27T00:46:21Z

/publish connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2393926478
❌ Failed to publish connectors/source-faker
❌ Couldn't auto-bump version for connectors/source-faker

evantahler · 2022-05-27T00:59:45Z

/publish connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2393972665
❌ Failed to publish connectors/source-faker
❌ Couldn't auto-bump version for connectors/source-faker

evantahler · 2022-05-27T02:42:10Z

/publish connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2394250957
❌ Failed to publish connectors/source-faker
❌ Couldn't auto-bump version for connectors/source-faker

davinchia · 2022-05-27T10:56:01Z

/publish connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2396090972
❌ Failed to publish connectors/source-faker
❌ Couldn't auto-bump version for connectors/source-faker

davinchia · 2022-05-27T11:02:33Z

@evantahler I confirmed this is still using the old AMI: https://github.com/airbytehq/airbyte/runs/6624320419?check_suite_focus=true#step:3:59

I believe we can test this by explicitly setting the AMI here. If this works, we modify the workflow to default to the previous AMI in a follow up PR.

davinchia · 2022-05-27T11:03:23Z

/publish connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2396121986
❌ Failed to publish connectors/source-faker
❌ Couldn't auto-bump version for connectors/source-faker

davinchia · 2022-05-27T11:21:54Z

Looks like that isn't working and we have to merge from master.

davinchia · 2022-05-27T15:31:50Z

/publish connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2397382697
❌ Failed to publish connectors/source-faker
❌ Couldn't auto-bump version for connectors/source-faker

evantahler · 2022-05-27T16:18:52Z

Making progress with the default image:

+ echo '--- docker info ---'
+ docker --version
--- docker info ---
Docker version 20.10.2, build 20.10.2-0ubuntu1~20.04.2
+ docker buildx version
github.com/docker/buildx v0.8.2 6224def4dd2c3d347eee19db595348c50d7cb491

Now the build is failing building the normalization image:

+ docker buildx build -t airbyte/integration-base-java:dev --platform linux/arm64 --load airbyte-integrations/bases/base-java

...

#6 [stage-2 1/7] WORKDIR /airbyte/integration_code
#6 DONE 0.2s

#7 [builder 2/4] RUN apk --no-cache upgrade     && pip install --upgrade pip     && apk --no-cache add tzdata build-base
#7 0.281 standard_init_linux.go:219: exec user process caused: exec format error
#7 ERROR: executor failed running [/bin/sh -c apk --no-cache upgrade     && pip install --upgrade pip     && apk --no-cache add tzdata build-base]: exit code: 1
------
 > [builder 2/4] RUN apk --no-cache upgrade     && pip install --upgrade pip     && apk --no-cache add tzdata build-base:
#7 0.281 standard_init_linux.go:219: exec user process caused: exec format error
------
error: failed to solve: executor failed running [/bin/sh -c apk --no-cache upgrade     && pip install --upgrade pip     && apk --no-cache add tzdata build-base]: exit code: 1
Error: Process completed with exit code 1.
##[debug]Finishing: Publish connectors/source-faker

Likely missing something needed for emulation...

evantahler · 2022-05-27T16:40:47Z

/publish connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2397691897
❌ Failed to publish connectors/source-faker
❌ Couldn't auto-bump version for connectors/source-faker

…into evan/faker-m1

evantahler · 2022-05-27T17:02:26Z

/publish connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2397782400
🚀 Successfully published connectors/source-faker
🚀 Auto-bumped version for connectors/source-faker
✅ connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2397782400

grubberr · 2022-05-27T17:14:39Z

$ cat Dockerfile
FROM alpine
RUN apk --no-cache upgrade

docker build .
Successfully built 20ad4fd30c56

docker buildx build .
[+] Building 0.9s (6/6) FINISHED

docker buildx build --platform linux/arm64 .
#5 0.278 standard_init_linux.go:228: exec user process caused: exec format error

…into evan/faker-m1

* Bump faker version to test M1 Connector builds * add PR link to changelog * Remove birhtday, it doesn't obey seed * bump readme * more birthday to remove * remove image specificity in publish-command * Set AMI for testing. * test with including buildx emulators * auto-bump connector version * add TODO comment Co-authored-by: Davin Chia <davinchia@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

evantahler marked this pull request as ready for review May 26, 2022 18:39

evantahler requested a review from sherifnada May 26, 2022 18:39

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 26, 2022

sherifnada approved these changes May 26, 2022

View reviewed changes

evantahler added 5 commits May 26, 2022 17:59

Bump faker version to test M1 Connector builds

0d6a605

add PR link to changelog

8a8dc80

Remove birhtday, it doesn't obey seed

faafe3b

bump readme

baa440e

more birthday to remove

f946406

evantahler force-pushed the evan/faker-m1 branch from 76b69d0 to f946406 Compare May 27, 2022 00:59

remove image specificity in publish-command

9c23ffc

evantahler temporarily deployed to more-secrets May 27, 2022 02:44 Inactive

Set AMI for testing.

d2c8c23

davinchia temporarily deployed to more-secrets May 27, 2022 11:05 Inactive

Merge remote-tracking branch 'origin/master' into evan/faker-m1

64e416e

evantahler added 2 commits May 27, 2022 10:01

test with including buildx emulators

66dd25e

Merge branch 'evan/faker-m1' of https://github.com/airbytehq/airbyte …

fa1c266

…into evan/faker-m1

evantahler temporarily deployed to more-secrets May 27, 2022 17:04 Inactive

auto-bump connector version

6bd7833

octavia-squidington-iii temporarily deployed to more-secrets May 27, 2022 17:22 Inactive

evantahler added 2 commits May 27, 2022 10:35

add TODO comment

57be406

Merge branch 'evan/faker-m1' of https://github.com/airbytehq/airbyte …

9509bcf

…into evan/faker-m1

evantahler merged commit e3cb566 into master May 27, 2022

evantahler deleted the evan/faker-m1 branch May 27, 2022 17:36

evantahler mentioned this pull request May 27, 2022

Publish connector Docker images for multiple platform architectures #13004

Merged

5 tasks

octavia-squidington-iii mentioned this pull request May 27, 2022

Bump Airbyte version from 0.39.4-alpha to 0.39.5-alpha #13288

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump faker version to test M1 Connector builds #13235

Bump faker version to test M1 Connector builds #13235

evantahler commented May 26, 2022

evantahler commented May 26, 2022 •

edited by github-actions bot

Loading

codecov bot commented May 26, 2022 •

edited

Loading

evantahler commented May 26, 2022 •

edited by github-actions bot

Loading

evantahler commented May 26, 2022

evantahler commented May 26, 2022 •

edited by github-actions bot

Loading

sherifnada commented May 26, 2022 •

edited by github-actions bot

Loading

evantahler commented May 26, 2022 •

edited by github-actions bot

Loading

evantahler commented May 27, 2022 •

edited by github-actions bot

Loading

evantahler commented May 27, 2022 •

edited by github-actions bot

Loading

evantahler commented May 27, 2022 •

edited by github-actions bot

Loading

evantahler commented May 27, 2022 •

edited by github-actions bot

Loading

davinchia commented May 27, 2022 •

edited by github-actions bot

Loading

davinchia commented May 27, 2022

davinchia commented May 27, 2022 •

edited by github-actions bot

Loading

davinchia commented May 27, 2022

davinchia commented May 27, 2022 •

edited by github-actions bot

Loading

evantahler commented May 27, 2022 •

edited

Loading

evantahler commented May 27, 2022 •

edited by github-actions bot

Loading

evantahler commented May 27, 2022 •

edited by github-actions bot

Loading

grubberr commented May 27, 2022

Bump faker version to test M1 Connector builds #13235

Bump faker version to test M1 Connector builds #13235

Conversation

evantahler commented May 26, 2022

evantahler commented May 26, 2022 • edited by github-actions bot Loading

Build Failed

codecov bot commented May 26, 2022 • edited Loading

Codecov Report

evantahler commented May 26, 2022 • edited by github-actions bot Loading

Build Passed

evantahler commented May 26, 2022

evantahler commented May 26, 2022 • edited by github-actions bot Loading

sherifnada commented May 26, 2022 • edited by github-actions bot Loading

evantahler commented May 26, 2022 • edited by github-actions bot Loading

evantahler commented May 27, 2022 • edited by github-actions bot Loading

evantahler commented May 27, 2022 • edited by github-actions bot Loading

evantahler commented May 27, 2022 • edited by github-actions bot Loading

evantahler commented May 27, 2022 • edited by github-actions bot Loading

davinchia commented May 27, 2022 • edited by github-actions bot Loading

davinchia commented May 27, 2022

davinchia commented May 27, 2022 • edited by github-actions bot Loading

davinchia commented May 27, 2022

davinchia commented May 27, 2022 • edited by github-actions bot Loading

evantahler commented May 27, 2022 • edited Loading

evantahler commented May 27, 2022 • edited by github-actions bot Loading

evantahler commented May 27, 2022 • edited by github-actions bot Loading

grubberr commented May 27, 2022

evantahler commented May 26, 2022 •

edited by github-actions bot

Loading

codecov bot commented May 26, 2022 •

edited

Loading

evantahler commented May 26, 2022 •

edited by github-actions bot

Loading

evantahler commented May 26, 2022 •

edited by github-actions bot

Loading

sherifnada commented May 26, 2022 •

edited by github-actions bot

Loading

evantahler commented May 26, 2022 •

edited by github-actions bot

Loading

evantahler commented May 27, 2022 •

edited by github-actions bot

Loading

evantahler commented May 27, 2022 •

edited by github-actions bot

Loading

evantahler commented May 27, 2022 •

edited by github-actions bot

Loading

evantahler commented May 27, 2022 •

edited by github-actions bot

Loading

davinchia commented May 27, 2022 •

edited by github-actions bot

Loading

davinchia commented May 27, 2022 •

edited by github-actions bot

Loading

davinchia commented May 27, 2022 •

edited by github-actions bot

Loading

evantahler commented May 27, 2022 •

edited

Loading

evantahler commented May 27, 2022 •

edited by github-actions bot

Loading

evantahler commented May 27, 2022 •

edited by github-actions bot

Loading