Update Facebook marketing API version #13251
Conversation
thinhnd2104
commented
May 27, 2022
thinhnd2104
commented
|
|
| @@ -161,7 +161,7 @@ class API: | |||
| def __init__(self, account_id: str, access_token: str): | |||
| self._account_id = account_id | |||
| # design flaw in MyFacebookAdsApi requires such strange set of new default api instance | |||
| self.api = MyFacebookAdsApi.init(access_token=access_token, crash_log=False) | |||
| self.api = MyFacebookAdsApi.init(access_token=access_token, crash_log=False, api_version='v14.0') | |||
There was a problem hiding this comment.
You need to change the facebook sdk version in setup.py. Please sign the CLA also and bump the connector version in the dockerfile and make sure you allow maintainer edit your PR.
There was a problem hiding this comment.
SDK version was not changed. Still 13.0.0 but API version is 14.0 @marcosmarxm
There was a problem hiding this comment.
@thinhnd2104 can you please summarize the API version changes and whether any of them impact the existing functionality in this connector?
|
With FB SDK: When API version changes but it only changes path on request uri. Ex: v13.0, v14.0. If not change API version, this connector does not work. |
|
@thinhnd2104 can you sign the CLA too? |
@sherifnada what your opinion here? |
@marcosmarxm any update for this? |
|
@thinhnd2104 exposing the version, while convenient on the surface, also potentially adds a lot of complexity because now the connector needs to support the features of all API versions. In any case, the first step to doing this is to understand how the changes in the new API version impact the connector's current functionality. My guess is it's much easier to upgrade this to the latest version than to maintain support for all possible API versions. |
|
Also selecting the API in code doesn't guaranty it will work with latest version of the Facebook API because of this we need to wait the release of new version of the Facebook Python SDK. Example is: removed endpoint, new endpoints etc. |
so how to get facebook data if API is not latest version? |
wait facebook release the new sdk version, probably you can create an issue in fb github repo or create an issue in their support. |
|
@thinhnd2104 I am still facing the same issue is this issue resolved?? |
|
|
@thinhnd2104 @marcosmarxm any chance to update to the new version https://pypi.org/project/facebook-business/ |
