Update API in order to support the per stream state #13468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api
…ate-api-for-per-stream
cgardens
requested changes
Jun 9, 2022
| type: array | ||
| items: | ||
| $ref: "#/components/schemas/StreamKey" | ||
| StreamKey: |
There was a problem hiding this comment.
reminder: replace thjs with stream descriptor
| @@ -3987,8 +4023,100 @@ components: | |||
| $ref: "#/components/schemas/ConnectionId" | |||
| state: | |||
There was a problem hiding this comment.
I am wondering about compatibility issues. I have no idea about how this endpoint is used (apart from it not being use in the UI). I some users have a script fetching the state, it should remains the same.
| type: string | ||
| enum: | ||
| - global | ||
| - per_stream |
There was a problem hiding this comment.
Suggested change
| - per_stream | |
| - stream |
| @@ -3987,8 +4023,100 @@ components: | |||
| $ref: "#/components/schemas/ConnectionId" | |||
| state: | |||
| $ref: "#/components/schemas/ConnectionStateObject" | |||
| globalState: | |||
…ate-api-for-per-stream
|
closing in favor #13835 so that other people can review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the API in order to handle the per stream state (and per stream reset).