Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Hubspot: scope crm.objects.feedback_submissions.read added for feedback_submissions stream #13475

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Jun 5, 2022

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Stream feedback_submissions requires crm.objects.feedback_submissions.read scope

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added the area/connectors Connector related issues label Jun 5, 2022
@grubberr grubberr self-assigned this Jun 5, 2022
@grubberr grubberr linked an issue Jun 5, 2022 that may be closed by this pull request
@grubberr
Copy link
Contributor Author

grubberr commented Jun 5, 2022

/test connector=connectors/source-hubspot

@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@12f51b7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 57548e2 differs from pull request most recent head fb215bf. Consider uploading reports for the commit fb215bf to get more accurate results

@@            Coverage Diff            @@
##             master   #13475   +/-   ##
=========================================
  Coverage          ?   91.24%           
=========================================
  Files             ?        4           
  Lines             ?      868           
  Branches          ?        0           
=========================================
  Hits              ?      792           
  Misses            ?       76           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f51b7...fb215bf. Read the comment docs.

@grubberr grubberr changed the title 🐛 Source Hubspot: crm.objects.feedback_submissions.read added 🐛 Source Hubspot: scope crm.objects.feedback_submissions.read added for FeedbackSubmissions stream Jun 5, 2022
@grubberr grubberr changed the title 🐛 Source Hubspot: scope crm.objects.feedback_submissions.read added for FeedbackSubmissions stream 🐛 Source Hubspot: scope crm.objects.feedback_submissions.read added for feedback_submissions stream Jun 5, 2022
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jun 5, 2022
@grubberr grubberr requested a review from girarda June 5, 2022 09:18
@grubberr
Copy link
Contributor Author

grubberr commented Jun 5, 2022

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2442946317
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2442946317
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_hubspot/errors.py         6      0   100%
source_hubspot/__init__.py       2      0   100%
source_hubspot/streams.py      767     58    92%
source_hubspot/source.py        93     18    81%
------------------------------------------------
TOTAL                          868     76    91%

Build Passed

Test summary info:

All Passed

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing!

@grubberr grubberr requested a review from lazebnyi June 6, 2022 06:10
@lazebnyi
Copy link
Collaborator

lazebnyi commented Jun 6, 2022

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2447243946
🚀 Successfully published connectors/source-hubspot
🚀 Auto-bumped version for connectors/source-hubspot
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2447243946

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets June 6, 2022 11:10 Inactive
@lazebnyi lazebnyi merged commit 7800b52 into master Jun 6, 2022
@lazebnyi lazebnyi deleted the grubberr/12911-source-hubspot branch June 6, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Hubspot: invalid permissions for feedback_submissions
4 participants