Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-acceptance-test: fix build #13485

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented Jun 6, 2022

What

Only the bases/source-acceptance-test name used to be handled correctly in the CI, unlike the source-acceptance-test. Now they both are.

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 6, 2022

/test connector=source-acceptance-test

🕑 source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2447000420
✅ source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2447000420
No Python unittests run

Build Passed

Test summary info:

All Passed

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 6, 2022

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2447006686
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2447006686
No Python unittests run

Build Passed

Test summary info:

All Passed

@davydov-d davydov-d self-assigned this Jun 6, 2022
@davydov-d davydov-d linked an issue Jun 6, 2022 that may be closed by this pull request
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 6, 2022

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2449171955
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2449171955
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/models.py                   18      0   100%
source_google_ads/__init__.py                  2      0   100%
source_google_ads/google_ads.py               67     10    85%
source_google_ads/streams.py                 163     26    84%
source_google_ads/source.py                   80     23    71%
source_google_ads/custom_query_stream.py      75     46    39%
--------------------------------------------------------------
TOTAL                                        405    105    74%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/models.py                   18      0   100%
source_google_ads/__init__.py                  2      0   100%
source_google_ads/streams.py                 163      8    95%
source_google_ads/source.py                   80      4    95%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/google_ads.py               67     12    82%
--------------------------------------------------------------
TOTAL                                        405     30    93%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 22 passed, 2 skipped in 154.75s (0:02:34) ===================

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 6, 2022

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/2449264494

@davydov-d
Copy link
Collaborator Author

pls ignore last two test runs ☝️ , I just needed to trigger them somewhere

@davydov-d davydov-d temporarily deployed to more-secrets June 6, 2022 17:18 Inactive
@davydov-d
Copy link
Collaborator Author

davydov-d commented Jun 6, 2022

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/2449703055
❌ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/2449703055
🐛 https://gradle.com/s/klqjmsapejdpo

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 SKIPPED [1] integration_tests/test_ephemeral.py:54: Destinations DestinationType.MYSQL is not in NORMALIZATION_TEST_TARGET env variable (MYSQL is also skipped)
	 SKIPPED [1] integration_tests/test_normalization.py:134: DestinationType.CLICKHOUSE is disabled as it doesnt support schema change in incremental yet (column type changes)
	 SKIPPED [1] integration_tests/test_normalization.py:75: Destinations DestinationType.CLICKHOUSE does not support nested streams
	 SKIPPED [1] integration_tests/test_normalization.py:137: DestinationType.MSSQL is disabled as it doesnt fully support schema change in incremental yet
	 SKIPPED [2] integration_tests/test_normalization.py:125: DestinationType.MYSQL does not support incremental yet
	 SKIPPED [1] integration_tests/test_normalization.py:125: DestinationType.ORACLE does not support incremental yet
	 SKIPPED [1] integration_tests/test_normalization.py:75: Destinations DestinationType.ORACLE does not support nested streams
	 SKIPPED [1] integration_tests/test_normalization.py:134: DestinationType.SNOWFLAKE is disabled as it doesnt support schema change in incremental yet (column type changes)
	 FAILED integration_tests/test_ephemeral.py::test_destination_supported_limits[DestinationType.REDSHIFT-1000]
	 �[31m============= �[31m�[1m1 failed�[0m, �[32m24 passed�[0m, �[33m9 skipped�[0m�[31m in 3351.63s (0:55:51)�[0m�[31m =============�[0m

@davydov-d davydov-d merged commit 20bd923 into master Jun 10, 2022
@davydov-d davydov-d deleted the ddavydov/fix-source-accptance-test-build branch June 10, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source-acceptance-test: build failed
3 participants