Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faker Source emits times in proper ISO format #13695

Merged
merged 3 commits into from
Jun 11, 2022
Merged

Conversation

evantahler
Copy link
Contributor

No description provided.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 10, 2022
@evantahler
Copy link
Contributor Author

evantahler commented Jun 10, 2022

/test connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2477444079
✅ connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2477444079
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                       Stmts   Miss  Cover
----------------------------------------------
source_faker/__init__.py       2      0   100%
source_faker/source.py       127      2    98%
----------------------------------------------
TOTAL                        129      2    98%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 21 passed, 1 skipped in 16.81s ========================

@evantahler evantahler marked this pull request as ready for review June 10, 2022 22:57
@evantahler
Copy link
Contributor Author

evantahler commented Jun 10, 2022

/publish connector=connectors/source-faker

🕑 connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2477917179
🚀 Successfully published connectors/source-faker
🚀 Auto-bumped version for connectors/source-faker
✅ connectors/source-faker https://github.com/airbytehq/airbyte/actions/runs/2477917179

@evantahler
Copy link
Contributor Author

This PR also exists to triple-check the /publish command after #13693

@evantahler evantahler changed the title Faker Source emits times in ISO format Faker Source emits times in proper ISO format Jun 10, 2022
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets June 10, 2022 23:21 Inactive
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@6c8cae2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13695   +/-   ##
=========================================
  Coverage          ?   98.44%           
=========================================
  Files             ?        2           
  Lines             ?      129           
  Branches          ?        0           
=========================================
  Hits              ?      127           
  Misses            ?        2           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8cae2...d9cbe30. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/faker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants