Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modal z-index bug #13724

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Fix modal z-index bug #13724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions airbyte-webapp/src/components/Modal/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import styled, { keyframes } from "styled-components";

import ContentCard from "components/ContentCard";

export interface IProps {
export interface ModalProps {
title?: string | React.ReactNode;
onClose?: () => void;
clear?: boolean;
Expand All @@ -26,10 +26,10 @@ const Overlay = styled.div`
display: flex;
justify-content: center;
align-items: center;
z-index: 10;
z-index: 100;
`;

const Modal: React.FC<IProps> = ({ children, title, onClose, clear, closeOnBackground }) => {
const Modal: React.FC<ModalProps> = ({ children, title, onClose, clear, closeOnBackground }) => {
const handleUserKeyPress = useCallback((event, closeModal) => {
const { keyCode } = event;
if (keyCode === 27) {
Expand Down