New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a simpler Getting Started with demo data #1408
Conversation
"destination_path": { | ||
"description": "Path to the directory where json files will be written. The files will be placed inside that local mount. For more information check out our <a href=\"https://docs.airbyte.io/integrations/destinations/local-json\">docs</a>", | ||
"type": "string", | ||
"examples": ["/json_data"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path should match what we're doing in local csv.
I'm fine with just putting it in a relative directory to the mount (and requiring no preceding slash) or doing it how we do it in local-csv where we require it to start with /local/
). Either way is fine if it matches.
This is how it's defined in local-csv:
"destination_path": {
"description": "Path to the directory where csv files will be written. Must start with the local mount \"/local\". Any other directory appended on the end will be placed inside that local mount. For more information check out our <a href=\"https://docs.airbyte.io/integrations/destinations/local-csv\">docs</a>",
"type": "string",
"examples": ["/local"],
"pattern": "(^\\/local\\/.*)|(^\\/local$)"
}
What
Create a simpler Getting Started with demo data
Create a local Json destination
How
Ensure a flawless experience when running and Airbyte for the first time
Also fix some weird documentation links
Recommended reading order
*.md
destination-local-json