Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Okta: add GroupMembers stream #14380

Merged

Commits on Jul 11, 2022

  1. add Group_Members stream to okta source

    - Group_Members return a list of users, the same schema of Users stream.
    - Create a shared schema users, and both group_members and users sechema use it as a reference.
    - Add Group_Members stream to source connector
    YiyangLi committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    0145ca6 View commit details
    Browse the repository at this point in the history
  2. add tests and fix logs schema

    - fix the test error: None is not one of enums though the enum type includes both string and null, it comes from json schema validator
    https://github.com/python-jsonschema/jsonschema/blob/ddb87afad8f5d5c40600b5ede0ab96e4d4bdf7d3/jsonschema/_validators.py#L279-L285
    - change grouop_members to use id as the cursor field since `filter` is not supported in the query string
    - fix the abnormal state test on logs stream, when since is abnormally large, until has to defined, an equal or a larger value
    - remove logs stream from full sync test, because 2 full sync always has a gap -- at least a new log about users or groups api.
    YiyangLi committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    57d0bf4 View commit details
    Browse the repository at this point in the history
  3. last polish before submit the PR

    - bump docker version
    - update changelog
    - add the right abnormal value for logs stream
    - correct the sample catalog
    YiyangLi committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    0dea6f2 View commit details
    Browse the repository at this point in the history
  4. address comments::

    - improve comments for until parameter under the logs stream
    - add use_cache on groupMembers
    YiyangLi committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    aa5bd8b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c84d548 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Configuration menu
    Copy the full SHA
    52d30c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    caf1f03 View commit details
    Browse the repository at this point in the history