normalization: bigquery partition pruning optimization #14485

brunofaustino · 2022-07-07T01:24:57Z

What

Change where clause to set a constant expression instead of a dynamic subselect query. It prevents BigQuery from scanning all of the partitions.
It's a known BigQuery issue: https://cloud.google.com/bigquery/docs/querying-partitioned-tables#best_practices_for_partition_pruning

This solves the issue: #14070

How

Add a DBT macro called bigquery__incremental_clause. This macro is dynamically dispatched by incremental_clause macro.

🚨 User Impact 🚨

BigQuery will be able to limit the partitions that are scanned in a query, optimizing cost and performance.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

alafanechere · 2022-07-08T10:07:56Z

Thank you @brunofaustino for opening this contribution! @edgao may I ask for a review? It looks like an important optimization considering the discussion on #14070 .

alafanechere · 2022-07-08T10:08:09Z

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/2635399145
✅ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/2635399145
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         162     34    79%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 570    377    34%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    587    57%
Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         162     34    79%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 570    377    34%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    587    57%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/utils.py                             38      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      5    97%
normalization/transform_catalog/stream_processor.py                 570     39    93%
normalization/transform_catalog/catalog_processor.py                147     12    92%
normalization/transform_catalog/dbt_macro.py                         22      3    86%
normalization/transform_catalog/table_name_registry.py              174     51    71%
normalization/transform_config/transform.py                         162     57    65%
normalization/transform_catalog/transform.py                         61     22    64%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    189    86%

Build Passed

Test summary info:

	 =========================== short test summary info ============================
	 SKIPPED [1] integration_tests/test_ephemeral.py:61: Destinations DestinationType.MYSQL is not in NORMALIZATION_TEST_TARGET env variable (MYSQL is also skipped)
	 SKIPPED [1] integration_tests/test_normalization.py:81: Destinations DestinationType.CLICKHOUSE does not support nested streams
	 SKIPPED [1] integration_tests/test_normalization.py:143: DestinationType.CLICKHOUSE is disabled as it doesnt support schema change in incremental yet (column type changes)
	 SKIPPED [1] integration_tests/test_normalization.py:146: DestinationType.MSSQL is disabled as it doesnt fully support schema change in incremental yet
	 SKIPPED [2] integration_tests/test_normalization.py:134: DestinationType.MYSQL does not support incremental yet
	 SKIPPED [1] integration_tests/test_normalization.py:81: Destinations DestinationType.ORACLE does not support nested streams
	 SKIPPED [1] integration_tests/test_normalization.py:134: DestinationType.ORACLE does not support incremental yet
	 SKIPPED [1] integration_tests/test_normalization.py:143: DestinationType.SNOWFLAKE is disabled as it doesnt support schema change in incremental yet (column type changes)
	 �[32m================== �[32m�[1m25 passed�[0m, �[33m9 skipped�[0m�[32m in 3025.38s (0:50:25)�[0m�[32m ==================�[0m
	 =========================== short test summary info ============================
	 SKIPPED [1] integration_tests/test_ephemeral.py:61: Destinations DestinationType.MYSQL is not in NORMALIZATION_TEST_TARGET env variable (MYSQL is also skipped)
	 SKIPPED [1] integration_tests/test_normalization.py:143: DestinationType.CLICKHOUSE is disabled as it doesnt support schema change in incremental yet (column type changes)
	 SKIPPED [1] integration_tests/test_normalization.py:81: Destinations DestinationType.CLICKHOUSE does not support nested streams
	 SKIPPED [1] integration_tests/test_normalization.py:146: DestinationType.MSSQL is disabled as it doesnt fully support schema change in incremental yet
	 SKIPPED [2] integration_tests/test_normalization.py:134: DestinationType.MYSQL does not support incremental yet
	 SKIPPED [1] integration_tests/test_normalization.py:134: DestinationType.ORACLE does not support incremental yet
	 SKIPPED [1] integration_tests/test_normalization.py:81: Destinations DestinationType.ORACLE does not support nested streams
	 SKIPPED [1] integration_tests/test_normalization.py:143: DestinationType.SNOWFLAKE is disabled as it doesnt support schema change in incremental yet (column type changes)
	 �[32m================== �[32m�[1m25 passed�[0m, �[33m9 skipped�[0m�[32m in 3798.51s (1:03:18)�[0m�[32m ==================�[0m

edgao

nice catch!

natalyjazzviolin · 2022-07-19T15:05:43Z

@brunofaustino looks like there are some conflicts that need to be resolved before this can be merged, do you have some time to take a look at them?

…ning

brunofaustino · 2022-07-19T15:48:01Z

@natalyjazzviolin Done! :)

edgao · 2022-07-19T21:35:21Z

/publish connector=bases/base-normalization

🕑 Publishing the following connectors:
bases/base-normalization
https://github.com/airbytehq/airbyte/actions/runs/2700741560

Connector	Did it publish?	Were definitions generated?
bases/base-normalization	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

edgao · 2022-07-19T21:37:04Z

@natalyjazzviolin fyi I'm running /publish, since the version numbers are somewhat conflict-prone (the only merge conflicts were in the version number + changelog); will merge once it finishes.

sashaNeshcheret · 2022-07-21T08:30:37Z

@edgao do we need to bump NORMALIZATION_VERSION in NormalizationRunnerFactory in scope of the ticket?

* bigquery partition pruning otimization * bump version and add changelog

edgao · 2022-07-21T15:56:06Z

@sashaNeshcheret I think the version bump already happened? https://github.com/airbytehq/airbyte/pull/14485/files#diff-968c6c1b743a3ad7d51f13669b2f2fae9b86d32d7698c5bc0eddf7613476be03

unless there's something else you're referring to

bigquery partition pruning otimization

8443ff3

github-actions bot added the normalization label Jul 7, 2022

octavia-squidington-iii added the community label Jul 7, 2022

bump version and add changelog

3b59395

github-actions bot added area/documentation Improvements or additions to documentation area/platform issues related to the platform area/worker Related to worker labels Jul 7, 2022

brunofaustino mentioned this pull request Jul 7, 2022

Destination BigQuery: Normalization SQL is not performing partition pruning (cost optimization) #14070

Closed

marcosmarxm requested a review from edgao July 7, 2022 12:34

alafanechere changed the title ~~bigquery partition pruning otimization~~ normalization: bigquery partition pruning optimization Jul 8, 2022

alafanechere assigned natalyjazzviolin Jul 11, 2022

alafanechere added internal area/connectors Connector related issues connectors/destination/bigquery and removed area/documentation Improvements or additions to documentation area/platform issues related to the platform labels Jul 11, 2022

edgao approved these changes Jul 14, 2022

View reviewed changes

Merge branch 'master' into bigquery-cost-otimization-by-partition-pru…

c00beb3

…ning

brunofaustino requested a review from a team as a code owner July 19, 2022 15:44

github-actions bot added area/documentation Improvements or additions to documentation area/platform issues related to the platform and removed area/connectors Connector related issues labels Jul 19, 2022

edgao approved these changes Jul 19, 2022

View reviewed changes

edgao merged commit f73e0c0 into airbytehq:master Jul 20, 2022

mfsiega-airbyte pushed a commit that referenced this pull request Jul 21, 2022

normalization: bigquery partition pruning optimization (#14485)

fcd5b9b

* bigquery partition pruning otimization * bump version and add changelog

octavia-squidington-iii mentioned this pull request Jul 23, 2022

Bump Airbyte version from 0.39.37-alpha to 0.39.38-alpha #14976

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

normalization: bigquery partition pruning optimization #14485

normalization: bigquery partition pruning optimization #14485

brunofaustino commented Jul 7, 2022

alafanechere commented Jul 8, 2022

alafanechere commented Jul 8, 2022 •

edited by github-actions bot

Loading

edgao left a comment

natalyjazzviolin commented Jul 19, 2022 •

edited

Loading

brunofaustino commented Jul 19, 2022

edgao commented Jul 19, 2022 •

edited by github-actions bot

Loading

edgao commented Jul 19, 2022

sashaNeshcheret commented Jul 21, 2022 •

edited

Loading

edgao commented Jul 21, 2022

normalization: bigquery partition pruning optimization #14485

normalization: bigquery partition pruning optimization #14485

Conversation

brunofaustino commented Jul 7, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

alafanechere commented Jul 8, 2022

alafanechere commented Jul 8, 2022 • edited by github-actions bot Loading

Build Passed

edgao left a comment

Choose a reason for hiding this comment

natalyjazzviolin commented Jul 19, 2022 • edited Loading

brunofaustino commented Jul 19, 2022

edgao commented Jul 19, 2022 • edited by github-actions bot Loading

edgao commented Jul 19, 2022

sashaNeshcheret commented Jul 21, 2022 • edited Loading

edgao commented Jul 21, 2022

alafanechere commented Jul 8, 2022 •

edited by github-actions bot

Loading

natalyjazzviolin commented Jul 19, 2022 •

edited

Loading

edgao commented Jul 19, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Jul 21, 2022 •

edited

Loading