🎉 Source Amazon Seller Partner: add FBA storage fees report #14625

ganpatagarwal · 2022-07-12T15:13:02Z

What

*Adding FBA storage fees report type

🚨 User Impact 🚨

No breaking change

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- [] Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit


Results (0.96s):
      93 passed
Name                                             Stmts   Miss  Cover   Missing
------------------------------------------------------------------------------
source_amazon_seller_partner/__init__.py             2      0   100%
source_amazon_seller_partner/auth.py                61     36    41%   24, 45, 48-99, 102-108
source_amazon_seller_partner/constants.py           37      1    97%   67
source_amazon_seller_partner/source.py              49     10    80%   100-111
source_amazon_seller_partner/spec.py                23      0   100%
source_amazon_seller_partner/streams.py            435    190    56%   64, 67, 70, 79, 84, 89, 94, 99, 104-116, 119-122, 128, 135-138, 186, 190, 193, 196, 199, 219-230, 239-254, 263-272, 275-282, 286-291, 297-302, 305-315, 318, 321, 334-367, 440-443, 450-451, 460-465, 469-498, 538, 547-556, 563-566, 572-594, 644, 658-663, 691, 696-698, 701, 704-708, 730, 735-746, 749, 762, 767, 802-806, 820, 837
unit_tests/test_finance_streams.py                  63      1    98%   157
unit_tests/test_reports_streams_rate_limits.py      33      0   100%
unit_tests/test_source.py                           42      0   100%
unit_tests/test_transform_function.py               23      0   100%
------------------------------------------------------------------------------
TOTAL                                              768    238    69%

Acceptance

python -m pytest integration_tests -p integration_tests.acceptance
Test session starts (platform: darwin, Python 3.9.11, pytest 6.1.2, pytest-sugar 0.9.4)
cachedir: .pytest_cache
rootdir: /Users/ganpatagarwal/stoke/airbyte, configfile: pytest.ini
plugins: sugar-0.9.4, mock-3.7.0, timeout-1.4.2
collecting ...
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_config_match_spec[inputs0] ✓                                         6% ▋
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_match_expected[inputs0] ✓                                           12% █▎
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_docker_env[inputs0] ✓                                               18% █▊
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_oneof_usage[inputs0] ✓                                              24% ██▍
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_required[inputs0] ✓                                                 29% ██▉
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_optional[inputs0] ✓                                                 35% ███▌
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_has_secret[inputs0] ✓                                               41% ████▎
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_secret_never_in_the_output[inputs0] ✓                               47% ████▊
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_defined_refs_exist_in_json_spec_file[inputs0] ✓                     53% █████▍
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_oauth_flow_parameters[inputs0] ✓                                    59% █████▉
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestConnection.test_check[inputs0] ✓                                              65% ██████▌
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestDiscovery.test_discover[inputs0] ✓                                            71% ███████▏
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestDiscovery.test_defined_cursors_exist_in_schema[inputs0] ✓                     76% ███████▋
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestDiscovery.test_defined_refs_exist_in_schema[inputs0] ✓                        82% ████████▎
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestDiscovery.test_defined_keyword_exist_in_schema[inputs0-allOf] ✓               88% ████████▉
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestDiscovery.test_defined_keyword_exist_in_schema[inputs0-not] ✓                 94% █████████▌
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestDiscovery.test_primary_keys_exist_in_schema[inputs0] ✓                       100% ██████████
{"type": "LOG", "log": {"level": "INFO", "message": "/Users/ganpatagarwal/stoke/airbyte/airbyte-integrations/connectors/source-amazon-seller-partner - SAT run - ae762ff44aaeaa0b3c2ec929ed8fe6131709c0b6 - PASSED"}}

================================================================================== short test summary info ===================================================================================
SKIPPED [1] ../../bases/source-acceptance-test/source_acceptance_test/plugin.py:56: Skipping TestBasicRead.test_read because not found in the config
SKIPPED [1] ../../bases/source-acceptance-test/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../../bases/source-acceptance-test/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config

Results (11.55s):
      17 passed

harshithmullapudi · 2022-07-15T09:47:32Z

Hey @ganpatagarwal could you resolve the conflicts

…azon-seller-partner-fba-storage-fees-report

ganpatagarwal · 2022-07-15T11:11:30Z

Hey @ganpatagarwal could you resolve the conflicts

Done !!

harshithmullapudi · 2022-07-15T12:28:13Z

/test connector=connectors/source-amazon-seller-partner

🕑 connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/2676839098
✅ connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/2676839098
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                        Stmts   Miss  Cover
---------------------------------------------------------------
source_amazon_seller_partner/spec.py           23      0   100%
source_amazon_seller_partner/__init__.py        2      0   100%
source_amazon_seller_partner/constants.py      37      1    97%
source_amazon_seller_partner/source.py         49     10    80%
source_amazon_seller_partner/streams.py       468    215    54%
source_amazon_seller_partner/auth.py           61     36    41%
---------------------------------------------------------------
TOTAL                                         640    262    59%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestBasicRead.test_read because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 17 passed, 3 skipped in 5.79s =========================

…tner-fba-storage-fees-report

harshithmullapudi · 2022-07-15T20:00:27Z

/test connector=connectors/source-amazon-seller-partner

🕑 connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/2679066250
✅ connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/2679066250
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                        Stmts   Miss  Cover
---------------------------------------------------------------
source_amazon_seller_partner/spec.py           23      0   100%
source_amazon_seller_partner/__init__.py        2      0   100%
source_amazon_seller_partner/constants.py      37      1    97%
source_amazon_seller_partner/source.py         49     10    80%
source_amazon_seller_partner/streams.py       468    215    54%
source_amazon_seller_partner/auth.py           61     36    41%
---------------------------------------------------------------
TOTAL                                         640    262    59%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestBasicRead.test_read because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 17 passed, 3 skipped in 5.80s =========================

harshithmullapudi · 2022-07-17T12:25:36Z

/publish connector=connectors/source-amazon-seller-partner

🕑 Publishing the following connectors:
connectors/source-amazon-seller-partner
https://github.com/airbytehq/airbyte/actions/runs/2685472563

Connector	Did it publish?	Were definitions generated?
connectors/source-amazon-seller-partner	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

ganpatagarwal added 3 commits July 12, 2022 20:25

enable stream for FBA Storage Fees Report

e5bd5a5

bump version

a496669

add stream details for FBA Storage Fees Report

ae762ff

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 12, 2022

octavia-squidington-iii added bounty community connectors/source/amazon-seller-partner labels Jul 12, 2022

update changelog

0b61dd8

alafanechere assigned harshithmullapudi Jul 12, 2022

Merge branch 'master' of https://github.com/airbytehq/airbyte into am…

aaf397c

…azon-seller-partner-fba-storage-fees-report

harshithmullapudi approved these changes Jul 15, 2022

View reviewed changes

harshithmullapudi added 2 commits July 16, 2022 00:45

Merge remote-tracking branch 'upstream/master' into amazon-seller-par…

ba99db9

…tner-fba-storage-fees-report

chore: formatting

96cc3a5

octavia-squidington-iii added the connectors/source/timely label Jul 15, 2022

auto-bump connector version

a461c7a

harshithmullapudi merged commit 638db80 into airbytehq:master Jul 17, 2022

ganpatagarwal deleted the amazon-seller-partner-fba-storage-fees-report branch July 18, 2022 07:16

octavia-squidington-iii mentioned this pull request Jul 23, 2022

Bump Airbyte version from 0.39.37-alpha to 0.39.38-alpha #14976

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Amazon Seller Partner: add FBA storage fees report #14625

🎉 Source Amazon Seller Partner: add FBA storage fees report #14625

ganpatagarwal commented Jul 12, 2022 •

edited

Loading

harshithmullapudi commented Jul 15, 2022

ganpatagarwal commented Jul 15, 2022

harshithmullapudi commented Jul 15, 2022 •

edited by github-actions bot

Loading

harshithmullapudi commented Jul 15, 2022 •

edited by github-actions bot

Loading

harshithmullapudi commented Jul 17, 2022 •

edited by github-actions bot

Loading

🎉 Source Amazon Seller Partner: add FBA storage fees report #14625

🎉 Source Amazon Seller Partner: add FBA storage fees report #14625

Conversation

ganpatagarwal commented Jul 12, 2022 • edited Loading

What

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

harshithmullapudi commented Jul 15, 2022

ganpatagarwal commented Jul 15, 2022

harshithmullapudi commented Jul 15, 2022 • edited by github-actions bot Loading

Build Passed

harshithmullapudi commented Jul 15, 2022 • edited by github-actions bot Loading

Build Passed

harshithmullapudi commented Jul 17, 2022 • edited by github-actions bot Loading

ganpatagarwal commented Jul 12, 2022 •

edited

Loading

harshithmullapudi commented Jul 15, 2022 •

edited by github-actions bot

Loading

harshithmullapudi commented Jul 15, 2022 •

edited by github-actions bot

Loading

harshithmullapudi commented Jul 17, 2022 •

edited by github-actions bot

Loading