🎉 Source Okta: OAuth2.0 authorization method #14710

annalvova05 · 2022-07-14T14:23:05Z

What

OAuth2.0 authorization method

How

Add oauth flow authorization.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

# Conflicts: # airbyte-integrations/connectors/source-okta/Dockerfile # airbyte-integrations/connectors/source-okta/acceptance-test-config.yml # airbyte-integrations/connectors/source-okta/source_okta/schemas/logs.json # airbyte-integrations/connectors/source-okta/source_okta/source.py # docs/integrations/sources/okta.md

annalvova05 · 2022-07-14T23:13:38Z

/test connector=connectors/source-okta

🕑 connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/2673660578
✅ connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/2673660578
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_okta/__init__.py       2      0   100%
source_okta/source.py       154     80    48%
---------------------------------------------
TOTAL                       156     80    49%

Build Passed

Test summary info:

All Passed

pedroslopez

Nice, good work on keeping compatibility with the old config 👍🏻

pedroslopez · 2022-07-18T14:41:38Z

airbyte-integrations/connectors/source-okta/source_okta/schemas/logs.json

@@ -38,11 +35,10 @@
          "type": ["string", "null"]
        },
        "authenticationStep": {
-          "type": ["integer", "null"]


Why are we removing these nulls? have we confirmed that these fields are really always set?

Documentation sets that these fields are not nullable.

# Conflicts: # airbyte-integrations/connectors/source-okta/source_okta/source.py # docs/integrations/sources/okta.md

annalvova05 · 2022-07-19T16:22:06Z

/test connector=connectors/source-okta

🕑 connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/2699094124
✅ connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/2699094124
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              298    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  964    246    74%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_okta/__init__.py       2      0   100%
source_okta/source.py       174     90    48%
---------------------------------------------
TOTAL                       176     90    49%

Build Passed

Test summary info:

All Passed

annalvova05 · 2022-07-19T16:31:57Z

/publish connector=connectors/source-okta

🕑 Publishing the following connectors:
connectors/source-okta
https://github.com/airbytehq/airbyte/actions/runs/2699148868

Connector	Did it publish?	Were definitions generated?
connectors/source-okta	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…of github.com:airbytehq/airbyte into alvova/7516-okta-oauth

annalvova05 added 4 commits July 11, 2022 18:16

add oauth

a1f1285

upd

a49fcbe

upd

aa956d3

upd

2bdb0a4

octavia-squidington-iii added the connectors/source/okta label Jul 14, 2022

github-actions bot added the area/connectors Connector related issues label Jul 14, 2022

annalvova05 added 2 commits July 14, 2022 17:25

upd doc

4b8cad9

upd version

0022288

github-actions bot added the area/documentation Improvements or additions to documentation label Jul 14, 2022

annalvova05 temporarily deployed to more-secrets July 14, 2022 14:27 Inactive

upd

1821363

annalvova05 temporarily deployed to more-secrets July 14, 2022 22:37 Inactive

annalvova05 temporarily deployed to more-secrets July 14, 2022 22:49 Inactive

upd

bd4c77d

annalvova05 temporarily deployed to more-secrets July 14, 2022 23:08 Inactive

upd logs schema

4906efe

annalvova05 temporarily deployed to more-secrets July 14, 2022 23:15 Inactive

annalvova05 self-assigned this Jul 15, 2022

annalvova05 linked an issue Jul 15, 2022 that may be closed by this pull request

oAuth backend for okta source #7516

Closed

annalvova05 marked this pull request as ready for review July 15, 2022 09:06

annalvova05 requested review from davydov-d and drrest July 15, 2022 09:08

drrest approved these changes Jul 15, 2022

View reviewed changes

davydov-d approved these changes Jul 15, 2022

View reviewed changes

annalvova05 requested a review from pedroslopez July 15, 2022 13:23

pedroslopez approved these changes Jul 18, 2022

View reviewed changes

annalvova05 added 2 commits July 19, 2022 18:52

Merge remote-tracking branch 'origin/master' into alvova/7516-okta-oauth

00dada2

# Conflicts: # airbyte-integrations/connectors/source-okta/source_okta/source.py # docs/integrations/sources/okta.md

remove oauth

a637543

annalvova05 temporarily deployed to more-secrets July 19, 2022 16:23 Inactive

octavia-squidington-iii and others added 3 commits July 19, 2022 16:46

auto-bump connector version [ci skip]

88acf1f

format

fe1ef29

Merge branches 'alvova/7516-okta-oauth' and 'alvova/7516-okta-oauth' …

a4fe5c5

…of github.com:airbytehq/airbyte into alvova/7516-okta-oauth

annalvova05 merged commit 352dd51 into master Jul 19, 2022

annalvova05 deleted the alvova/7516-okta-oauth branch July 19, 2022 17:02

annalvova05 temporarily deployed to more-secrets July 19, 2022 17:03 Inactive

octavia-squidington-iii mentioned this pull request Jul 23, 2022

Bump Airbyte version from 0.39.37-alpha to 0.39.38-alpha #14976

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Okta: OAuth2.0 authorization method #14710

🎉 Source Okta: OAuth2.0 authorization method #14710

annalvova05 commented Jul 14, 2022 •

edited

Loading

annalvova05 commented Jul 14, 2022 •

edited by github-actions bot

Loading

pedroslopez left a comment

pedroslopez Jul 18, 2022

annalvova05 Jul 18, 2022

annalvova05 commented Jul 19, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jul 19, 2022 •

edited by github-actions bot

Loading

🎉 Source Okta: OAuth2.0 authorization method #14710

🎉 Source Okta: OAuth2.0 authorization method #14710

Conversation

annalvova05 commented Jul 14, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

annalvova05 commented Jul 14, 2022 • edited by github-actions bot Loading

Build Passed

pedroslopez left a comment

Choose a reason for hiding this comment

pedroslopez Jul 18, 2022

Choose a reason for hiding this comment

annalvova05 Jul 18, 2022

Choose a reason for hiding this comment

annalvova05 commented Jul 19, 2022 • edited by github-actions bot Loading

Build Passed

annalvova05 commented Jul 19, 2022 • edited by github-actions bot Loading

annalvova05 commented Jul 14, 2022 •

edited

Loading

annalvova05 commented Jul 14, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jul 19, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Jul 19, 2022 •

edited by github-actions bot

Loading