Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-jdbc source connectors: Remove additional properties from beta/GA specs and schemas #14924

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jul 21, 2022

What

Before merging #14878 I fix beta and GA connectors whose acceptance tests might fail after adding this new rule:

  • Connectors must not use additionalProperties set to anything else than true in their JSON spec and stream schemas.

How

  • Edit spec.json and schemas of the following connectors:
source_name status
source-amplitude generally_available
source-stripe generally_available
source-intercom generally_available
source-linkedin-ads generally_available
source-google-search-console beta
source-notion beta
source-snapchat-marketing beta
source-mixpanel beta

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 21, 2022
@alafanechere alafanechere changed the title Remove additional properties from beta/GA connector specs non-jdbc source connectors: Remove additional properties from beta/GA specs and schemas Jul 21, 2022
@alafanechere alafanechere marked this pull request as ready for review July 21, 2022 17:57
Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉Connectors Build was failing on the latest commit, but I re-ran it and seems fine now

docs/integrations/sources/intercom.md Outdated Show resolved Hide resolved
Co-authored-by: Pedro S. Lopez <pedroslopez@me.com>
@alafanechere
Copy link
Contributor Author

alafanechere commented Jul 22, 2022

/publish connector=connectors/source-amplitude,connectors/source-stripe,connectors/source-intercom,connectors/source-linkedin-ads,connectors/source-google-search-console,connectors/source-notion,connectors/source-snapchat-marketing,connectors/source-mixpanel

🕑 Publishing the following connectors:
connectors/source-amplitude,connectors/source-stripe,connectors/source-intercom,connectors/source-linkedin-ads,connectors/source-google-search-console,connectors/source-notion,connectors/source-snapchat-marketing,connectors/source-mixpanel
https://github.com/airbytehq/airbyte/actions/runs/2717206083


Connector Did it publish? Were definitions generated?
connectors/source-intercom
connectors/source-amplitude
connectors/source-stripe
connectors/source-linkedin-ads
connectors/source-google-search-console
connectors/source-notion
connectors/source-snapchat-marketing
connectors/source-mixpanel

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants