Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source File: bump setup.py versions #15269

Merged
merged 5 commits into from Aug 6, 2022
Merged

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Aug 3, 2022

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Update https://pypi.org/project/smart-open/ because we need this piskvorky/smart_open#646

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr self-assigned this Aug 3, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Aug 3, 2022
@grubberr
Copy link
Contributor Author

grubberr commented Aug 3, 2022

/test connector=connectors/source-file

@grubberr
Copy link
Contributor Author

grubberr commented Aug 4, 2022

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2794380239
❌ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2794380239
🐛 https://gradle.com/s/t4znmb4ru7qia

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[S3-s3:/gdelt-open-data/events/20190914.export.csv-58-\\t-False0]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[S3-s3:/gdelt-open-data/events/20190914.export.csv-58-\\t-False1]
	 �[31m================== �[31m�[1m2 failed�[0m, �[32m30 passed�[0m, �[33m2 warnings�[0m�[31m in 30.88s�[0m�[31m ===================�[0m

@grubberr grubberr linked an issue Aug 5, 2022 that may be closed by this pull request
@grubberr grubberr changed the title bump versions 🎉 Source File: bump setup.py versions Aug 5, 2022
@grubberr
Copy link
Contributor Author

grubberr commented Aug 5, 2022

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2806061661
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2806061661
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        82      6    93%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  77     17    78%
source_acceptance_test/tests/test_core.py              355    107    70%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                 1023    247    76%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       256     39    85%
source_file/source.py        50     35    30%
---------------------------------------------
TOTAL                       308     74    76%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/source.py        50     27    46%
source_file/client.py       256    158    38%
---------------------------------------------
TOTAL                       308    185    40%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 29 passed, 1 skipped in 57.37s ========================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 5, 2022
@grubberr
Copy link
Contributor Author

grubberr commented Aug 6, 2022

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2808267431
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2808267431
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        82      6    93%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  77     17    78%
source_acceptance_test/tests/test_core.py              355    107    70%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                 1023    247    76%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       256     39    85%
source_file/source.py        50     35    30%
---------------------------------------------
TOTAL                       308     74    76%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/source.py        50     27    46%
source_file/client.py       256    158    38%
---------------------------------------------
TOTAL                       308    185    40%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 29 passed, 1 skipped in 57.76s ========================

@grubberr
Copy link
Contributor Author

grubberr commented Aug 6, 2022

/publish connector=connectors/source-file

🕑 Publishing the following connectors:
connectors/source-file
https://github.com/airbytehq/airbyte/actions/runs/2808319151


Connector Did it publish? Were definitions generated?
connectors/source-file

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr grubberr merged commit 35125f8 into master Aug 6, 2022
@grubberr grubberr deleted the grubberr/5537-source-file branch August 6, 2022 09:28
@girarda
Copy link
Contributor

girarda commented Aug 8, 2022

/publish connector=connectors/source-file-secure

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source File: ability to get HTTPS attachments
4 participants