Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Source Harvest: “started_time” being incorrectly cast as datetime field #15312

Merged
merged 9 commits into from
Aug 8, 2022

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Aug 4, 2022

What

#11980 - Harvest “started_time” being incorrectly cast as datetime field

How

Deleted format from schema for started_time and ended_time.
Added slices for report streams and custom backoff logic.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 4, 2022
@lazebnyi lazebnyi linked an issue Aug 4, 2022 that may be closed by this pull request
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 4, 2022

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/2797663897
❌ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/2797663897
🐛 https://gradle.com/s/46pfdcwp3il7i

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/unit_test.py::test_report_base_stream - TypeError: 'NoneTyp...
	 �[31m=================== �[31m�[1m1 failed�[0m, �[32m7 passed�[0m, �[33m91 warnings�[0m�[31m in 0.43s�[0m�[31m ===================�[0m

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 4, 2022

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/2797681521
❌ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/2797681521
🐛 https://gradle.com/s/ovyt3w744vnju

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/unit_test.py::test_report_base_stream - TypeError: 'NoneTyp...
	 �[31m=================== �[31m�[1m1 failed�[0m, �[32m7 passed�[0m, �[33m91 warnings�[0m�[31m in 0.44s�[0m�[31m ===================�[0m

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 4, 2022

/test connector=connectors/source-harvest

🕑 connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/2797785197
✅ connectors/source-harvest https://github.com/airbytehq/airbyte/actions/runs/2797785197
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        81      6    93%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  77     17    78%
source_acceptance_test/tests/test_core.py              328    121    63%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  995    261    74%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_harvest/auth.py          11      0   100%
source_harvest/__init__.py       2      0   100%
source_harvest/source.py        33      1    97%
source_harvest/streams.py      166     24    86%
------------------------------------------------
TOTAL                          212     25    88%

Build Passed

Test summary info:

All Passed

@lazebnyi lazebnyi marked this pull request as ready for review August 4, 2022 16:15
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Aug 8, 2022

/publish connector=connectors/source-harvest

🕑 Publishing the following connectors:
connectors/source-harvest
https://github.com/airbytehq/airbyte/actions/runs/2817410572


Connector Did it publish? Were definitions generated?
connectors/source-harvest

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@lazebnyi lazebnyi merged commit 43e7fbb into master Aug 8, 2022
@lazebnyi lazebnyi deleted the lazebnyi/11980-harvest-fix-schema-format-error branch August 8, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/harvest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harvest “started_time” being incorrectly cast as datetime field
4 participants