migrate sentry to config-based cdk #15345
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| definitions: | ||
| page_size: 50 | ||
| schema_loader: | ||
| type: JsonSchema | ||
| file_path: "./source_sentry/schemas/{{ options.name }}.json" | ||
| selector: | ||
| type: RecordSelector | ||
| extractor: | ||
| type: DpathExtractor | ||
| field_pointer: [] | ||
| requester: | ||
| type: HttpRequester | ||
| name: "{{ options['name'] }}" | ||
| url_base: "https://{{ config.hostname }}/api/0/" | ||
| http_method: "GET" | ||
| authenticator: | ||
| type: "BearerAuthenticator" | ||
| api_token: "{{ config.auth_token }}" | ||
| paginator: | ||
| type: LimitPaginator | ||
| url_base: "*ref(definitions.requester.url_base)" | ||
|
There was a problem hiding this comment. why are we passing url_base to the paginator? There was a problem hiding this comment. a bit of an implementation detail, but it's to replace the base url from the cursor when updating the path. although maybe that could be done in the retriever. left a comment on this |
||
| page_size: "*ref(definitions.page_size)" | ||
| limit_option: | ||
| inject_into: "request_parameter" | ||
| field_name: "" | ||
|
There was a problem hiding this comment. a bit absurd to to need this... cursor pagination should be a first-class paginator There was a problem hiding this comment. what does it mean to have an empty field_name? is this correct? There was a problem hiding this comment. the right solution here is probably for |
||
| page_token_option: | ||
| inject_into: "request_parameter" | ||
| field_name: "cursor" | ||
| pagination_strategy: | ||
| type: "CursorPagination" | ||
| cursor_value: "{{ headers.link.next.cursor }}" | ||
| stop_condition: "{{ headers.link.next.results != 'true' }}" | ||
| retriever: | ||
| type: SimpleRetriever | ||
| name: "{{ options['name'] }}" | ||
| primary_key: "{{ options['primary_key'] }}" | ||
|
|
||
| streams: | ||
| - type: DeclarativeStream | ||
| $options: | ||
| # https://docs.sentry.io/api/events/list-a-projects-events/ | ||
| name: "events" | ||
girarda marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| primary_key: "id" | ||
| schema_loader: | ||
| $ref: "*ref(definitions.schema_loader)" | ||
| retriever: | ||
| $ref: "*ref(definitions.retriever)" | ||
| record_selector: | ||
| $ref: "*ref(definitions.selector)" | ||
| requester: | ||
| $ref: "*ref(definitions.requester)" | ||
| path: "projects/{{config.organization}}/{{config.project}}/events/" | ||
| request_options_provider: | ||
| request_parameters: | ||
| full: "true" | ||
| paginator: | ||
| $ref: "*ref(definitions.paginator)" | ||
| - type: DeclarativeStream | ||
| $options: | ||
| name: "issues" | ||
| primary_key: "id" | ||
| schema_loader: | ||
| $ref: "*ref(definitions.schema_loader)" | ||
| retriever: | ||
| $ref: "*ref(definitions.retriever)" | ||
| record_selector: | ||
| $ref: "*ref(definitions.selector)" | ||
| requester: | ||
| $ref: "*ref(definitions.requester)" | ||
| path: "projects/{{config.organization}}/{{config.project}}/issues/" | ||
| request_options_provider: | ||
| request_parameters: | ||
| statsPeriod: "" | ||
| query: "" | ||
| paginator: | ||
| $ref: "*ref(definitions.paginator)" | ||
| - type: DeclarativeStream | ||
| $options: | ||
| name: "projects" | ||
| primary_key: "id" | ||
| schema_loader: | ||
| $ref: "*ref(definitions.schema_loader)" | ||
| retriever: | ||
| $ref: "*ref(definitions.retriever)" | ||
| record_selector: | ||
| $ref: "*ref(definitions.selector)" | ||
| requester: | ||
| $ref: "*ref(definitions.requester)" | ||
| path: "projects/" | ||
| paginator: | ||
|
There was a problem hiding this comment. this seems incorrect? https://docs.sentry.io/api/projects/list-your-projects/ has paginatino There was a problem hiding this comment. good catch. also added it to the issues stream |
||
| $ref: "*ref(definitions.paginator)" | ||
| - type: DeclarativeStream | ||
| $options: | ||
| name: "project_detail" | ||
| primary_key: "id" | ||
| schema_loader: | ||
| $ref: "*ref(definitions.schema_loader)" | ||
| retriever: | ||
| $ref: "*ref(definitions.retriever)" | ||
| record_selector: | ||
| $ref: "*ref(definitions.selector)" | ||
| requester: | ||
| $ref: "*ref(definitions.requester)" | ||
| path: "projects/{{config.organization}}/{{config.project}}/" | ||
| paginator: | ||
| type: NoPagination | ||
| check: | ||
| type: CheckStream | ||
| stream_names: ["project_detail"] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the test account doesn't have enough data to test the pagination...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about our actual sentry account?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! I was able to test the pagination on the events stream. The same pagination is used for issues and projects.
project_detailsdoes not have pagination https://docs.sentry.io/api/projects/retrieve-a-project/