Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Freshdesk: fix spec for backward compatibility #15378

Merged
merged 3 commits into from
Aug 6, 2022

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Aug 5, 2022

What

Resolves: #15377

How

  • edited spec.json to support backward compatibility.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 5, 2022
@bazarnov
Copy link
Collaborator Author

bazarnov commented Aug 6, 2022

/publish connector=connectors/source-freshdesk

🕑 Publishing the following connectors:
connectors/source-freshdesk
https://github.com/airbytehq/airbyte/actions/runs/2808491256


Connector Did it publish? Were definitions generated?
connectors/source-freshdesk

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@bazarnov bazarnov merged commit 2d92864 into master Aug 6, 2022
@bazarnov bazarnov deleted the bazarnov/15377-fix-spec branch August 6, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/freshdesk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎉 Source Freshdesk: fix spec for backward compatibility
4 participants